Anchor for citation not working as expected about grav-plugin-shortcode-citation HOT 6 CLOSED

Hi @paulhibbitts. Thanks for your feedback and testing!

You are very correct that there's currently an issue with the anchors!

They are missing the cite- part in the templates, so I've fixed that now, but there seems to be a wider issue with numeric IDs. This will be caused by PHP and/or Twig treating the numeric ID as an index of the list, rather than as a key. I'll have a play around tomorrow and fix this.

The plugin only shows references that have been cited in the page, so only one showing up is by design if you have only cited one. Thinking about it now, I can imagine a use-case where someone wants all to show even if some are not explicitly cited, and perhaps even to use it as a list of references for further reading without any explicit citations. I'll try to implement a configuration option for this.

I'll create a configurable default in the plugin config, a page header override, and something like `[cite all=true /]' for the shortcode.

If you have any feature requests, feel free to create issues for them.

from grav-plugin-shortcode-citation.

Thanks for looking into this @N-Parsons. The new release helps the anchor issue but looks like other issues remain as you allude to. If it helps, here is my test Markdown:

---
title: 'Test Page'
date: '14:15 24-07-2019'
references:
    -
        id: '1'
        type: book
        title: 'Reference One'
    -
        id: '2'
        type: book
        title: 'Reference Two'
---

Some sample text. [cite=1 /]

More sample text.[cite=2 /]

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

And yet some more sample text.  

[cite /] 

And here is the resulting page:

Thanks again, and please let me know when it's a good time for me to test things again.
Paul

from grav-plugin-shortcode-citation.

Hi @paulhibbitts. The issue with numeric IDs is now fixed in the latest release. I've tested it, and it seems to be working correctly, so I'll close this issue now, but if you have any more trouble, just give me a shout.

I will continue to work on the extra configuration options.

from grav-plugin-shortcode-citation.

@paulhibbitts, the extra functionality discussed above has now been added in PR #3 if you want to test it again. :)

from grav-plugin-shortcode-citation.

Thanks so much @N-Parsons , I can confirm that the issue of the missing citation is now not present. Not quite sure if I was able to download and install the right ZIP archive for testing the PR... once you are ready to release I will re-test and report back. Thanks again for this really useful Plugin for open educators and publishers!

from grav-plugin-shortcode-citation.

Hi @paulhibbitts, you can now grab the pre-release from here: https://github.com/N-Parsons/grav-plugin-shortcode-citation/releases/tag/v0.2-alpha

from grav-plugin-shortcode-citation.