Giter VIP home page Giter VIP logo

Comments (4)

N-Wouda avatar N-Wouda commented on June 10, 2024

I think that makes sense. To not break the current code, I think we should consider an addition:

def on_best(self, func):
    self.on_outcome(func, Outcome.BEST)

def on_outcome(self, func, outcome):
    self._on_outcome[outcome] = func

from alns.

N-Wouda avatar N-Wouda commented on June 10, 2024

Since the actual amount of code needed for this is very small, we could also just do on_best, on_better, on_accept, on_reject as explicit methods, rather than expose the Outcome enum to the users.

from alns.

N-Wouda avatar N-Wouda commented on June 10, 2024

This comment is relevant here:

Should we create an IntEnum for the evaluation outcome, and pass that to update, rather than a meaningless integer s_idx?

I'm thinking of

import enum

class Outcome(enum.IntEnum):
    BEST = 0
    BETTER = 1
    ACCEPTED = 2
    REJECTED = 3

Originally posted by @N-Wouda in #74 (comment)

from alns.

N-Wouda avatar N-Wouda commented on June 10, 2024

This one's pretty easy as well. I will try to finish this one tonight, so we can submit our JOSS paper (#58). @leonlan could you review the resulting PR?

from alns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.