Add support for submodules about gradle-git-properties HOT 10 CLOSED

I ran into this same issue for a project with submodules, and I simply cannot build or test any subproject with the gradle-git-properties dependency. Very annoying.

Since maintainers did not respond (yet), maybe you can attempt to make a pull request, @Plaputta ?

from gradle-git-properties.

@Plaputta @jesperronn Were you guys able to sort this out?

from gradle-git-properties.

I have the same problem.
The .git folder of submodule base here - ../../.git/modules/hri-backend/modules/user-service
But when I try:
gitRepositoryRoot = new File("${project.rootProject.rootDir}../../.git/modules/hri-backend/modules/user-service")

I get:
org.eclipse.jgit.errors.RepositoryNotFoundException: repository not f
ound: C:\IdeaProjects\hri\hri-backend\user-service.git

And I can't understand - why it try to find .git folder at C:\IdeaProjects\hri\hri-backend\user-service.git

P.S. When I try to get path and print it:
println new File("${project.rootProject.rootDir}/../../.git/modules/hri-backend/modules/user-service").getPath()

And result:

from gradle-git-properties.

@soxsten The current version of the plugin doesn't support git modules. I'm submitting PR #59 to support detecting .git files for git modules

from gradle-git-properties.

@tha2015
Well... Thank you for the fast respose.
How quickly will you realize this feature?

from gradle-git-properties.

Feature is implemented in PR #59 and is ready to be reviewed by @n0mer .
We will have to wait for @n0mer to merge it into the main branch and release it in the next version of the plugin.

from gradle-git-properties.

@soxsten are you willing to try this feature once it's released?

I'm going to publish new 1.4.22 version soon, once #52 regression is fixed.

Just wondering - do you guys @soxsten @tha2015 use java 8?

from gradle-git-properties.

I'm using Java 8 (with Gradle) for my everyday job. But I'm also using Java 6 when fixing bugs for an old branch (which is built by Ant, not Gradle).
I guess people using Java 6 not likely build with Gradle. So it might be OK to stop supporting Java versions < 8.

from gradle-git-properties.

@n0mer
Yes I will. It's very interesting for me. I can wait a bit.
P.S. I use Java 8 with Gradle too.
P.P.S. I'll be very appreciate if you notify me when you realize it

from gradle-git-properties.

Code merged. Should be fixed in next version 1.4.22

from gradle-git-properties.