`filestations.upload_file(...)` does not return anything meaninful anymore about synology-api HOT 5 CLOSED

Hi @N4S4,

thanks for you hint. Okay, things are confusing, I try to clarify:

• The Upload Complete message is perfectly returned in 0.4.4
• I checked the code for upload_file(...) in filestation.py for tag 0.5 and everything looks good:

  synology-api/synology_api/filestation.py

  Lines 504 to 529 in 44ab8e9

  	def upload_file(self, dest_path, file_path, create_parents=True, overwrite=True, verify=False):
  	api_name = 'SYNO.FileStation.Upload'
  	info = self.file_station_list[api_name]
  	api_path = info['path']
  	filename = os.path.basename(file_path)
  	session = requests.session()
  	with open(file_path, 'rb') as payload:
  	url = ('%s%s' % (self.base_url, api_path)) + '?api=%s&version=%s&method=upload&_sid=%s' % (
  	api_name, info['minVersion'], self._sid)
  	args = {
  	'path': dest_path,
  	'create_parents': str(create_parents).lower(),
  	'overwrite': str(overwrite).lower(),
  	}
  	files = {'file': (filename, payload, 'application/octet-stream')}
  	r = session.post(url, data=args, files=files, verify=verify)
  	if r.status_code == 200 and r.json()['success']:
  	return 'Upload Complete'
  	else:
  	return r.status_code, r.json()

• But then I installed 0.5 with pip and here the problem occurs. I checked the source code on pypi and saw that upload_file(...) in filestation.py looks different and causes the described problem ....

Am I doing something wrong or is there a diff between 0.5 on Github and pypi?

Thanks!

Best,
@PanchoVarallo

from synology-api.

Sorry for the delay.

Looks perfectly now. Thanks for the fast fix. Now I can upgrade ...

from synology-api.

Hi,
the upload function did not change through the versions, strange did not output anything.
I just run it and got it successful,

Is that really wanted?

actually not

can you show (if feasible your request? was the upload successful but output nothing?

from synology-api.

Oh no you might be right!
I maybe accidentally upload a different file while i was trying to make upload in chunks! I will have a look straight away and let you know

Thank you for reporting!

from synology-api.

Hi,

could you check it now? tnx again

from synology-api.