Add more encoders/decoders about adobe-brackets-encode-decode HOT 19 CLOSED

HI Nadchif,
I would like to contribute. Your contributing guide is really detailed - great job on it!

from adobe-brackets-encode-decode.

FYI - I'm working on Roman <--> Decimal

from adobe-brackets-encode-decode.

Hey @nadchif, I'm completed and tested Decimal-> Roman. Two questions for you: (1) Does it make sense to go ahead and submit pull request for this conversion alone, or shall I wait until I complete the Roman->Decimal and submit both together?

from adobe-brackets-encode-decode.

@nadchif here is the second item: May I please get your input on setting limits on the size of the decimal being converted? By definition, Roman numerals are not meant for massive numbers; thus M (1000) as the largest. So if you want to see 50K, it will print to 50 "M's"; my sense is to set a limit of perhaps 4, possibly 5 digits. Browserling doesn't appear to set a practical limit (I didn't try a million yet). I dislike the idea of allowing someone to print out a thousand "M's" just because they can. Also, someone may make an error and type in a huge number without meaning to, etc. Thoughts??

from adobe-brackets-encode-decode.

Hi @nadchif i would like to contribute.

from adobe-brackets-encode-decode.

uh-oh, I forgot to @nadchif in my original comment. I would like to contribute, please

from adobe-brackets-encode-decode.

This project is gathering so much contribution! Awesome to all. and @nadchif

from adobe-brackets-encode-decode.

Thanks, @nadchif ; I'll go ahead and start working on the Roman --> Decimal conversion. Thanks for the snippet - I leveraged same from some of your code when I checked that the input is all digits for the decimal conversion. I appreciate that you are so helpful!

from adobe-brackets-encode-decode.

@Mayank2901 Sure, please go ahead ☺

from adobe-brackets-encode-decode.

@nourmab13 thank you. Please go ahead ☺

from adobe-brackets-encode-decode.

Thats a nice one! looking forward to your contribution 😄

from adobe-brackets-encode-decode.

Hey @nadchif, I'm completed and tested Decimal-> Roman. Two questions for you: (1) Does it make sense to go ahead and submit pull request for this conversion alone, or shall I wait until I complete the Roman->Decimal and submit both together?

Hey @nourmab13 I'm glad to hear you are done with the Decimal -> Roman conversion. 👏 You may go ahead and work on the Roman -> Decimal. No pressure, no rush 😄

from adobe-brackets-encode-decode.

@nadchif here is the second item: May I please get your input on setting limits on the size of the decimal being converted? By definition, Roman numerals are not meant for massive numbers; thus M (1000) as the largest. So if you want to see 50K, it will print to 50 "M's"; my sense is to set a limit of perhaps 4, possibly 5 digits. Browserling doesn't appear to set a practical limit (I didn't try a million yet). I dislike the idea of allowing someone to print out a thousand "M's" just because they can. Also, someone may make an error and type in a huge number without meaning to, etc. Thoughts??

😆 This is a valid concern. I think it would be a great idea to implement a limit. If you plan on communicating back to the user, here is a snippet that might help:

  const Dialogs = brackets.getModule('widgets/Dialogs');
  Dialogs.showModalDialog('',
          '{Add your Dialog Title Here}',
          '{Add your dialog message here}');
  }

from adobe-brackets-encode-decode.

It's a pleasure 🙏

Happy Coding! 💻

from adobe-brackets-encode-decode.

Hi @nadchif - I created a pull request, and I see it on my fork, not on the main repository (is that correct?). I just wanted to confirm that I submitted it correctly. Thanks!

from adobe-brackets-encode-decode.

@nourmab13 yooohoooo! 👏 😁
The pull request you opened, will update your fork's master branch by merging the latest commits from this master.

Please go ahead and merge that PR into your master. Once you are done, you can create pull request using this link master...nourmab13:master

from adobe-brackets-encode-decode.

from adobe-brackets-encode-decode.

Hi again. Please make sure you

1. commit your local changes

git commit -m "description message" 

2. Then push the changes to your fork's master branch

git push

I think that would resolve this problem

from adobe-brackets-encode-decode.

from adobe-brackets-encode-decode.