Giter VIP home page Giter VIP logo

Comments (3)

nalexn avatar nalexn commented on May 30, 2024 1

Hey @nfrydenholm

I double-checked the view extraction code and found out that the requirement for the generic parameter to match the actual inner view type was unnecessary, so this requirement is removed in v0.3.14

The base view type still has to match, but if it has a generic parameter, you can substitute any view type, such as AnyView or EmptyView:

.view(FormBaseView<EmptyView>.self).viewBuilder()

from viewinspector.

nalexn avatar nalexn commented on May 30, 2024

Hey @nfrydenholm

It turned out that ViewInspector was unable to extract the @ViewBuilder's content. I've added support for this in v0.3.13

let view = FormBaseView {
    Spacer()
    Text("Abc")
}

let sut = try view.inspect().viewBuilder().text(1)
let view = AnyView(FormBaseView { Text("Abc") })

let sut = try view.inspect().anyView().view(FormBaseView<Text>.self).viewBuilder().text(0)

// When content is 2 or more views:
.view(FormBaseView<TupleView<(Spacer, Text)>>.self)

from viewinspector.

nfrydenholm avatar nfrydenholm commented on May 30, 2024

Thanks @nalexn - that was a quick reaction to my question - much appreciated 🙇‍♂️ 👍

I got it working based on the examples you provided. 👏

I did bump into an issue, where I had to make a minor change to my code.

Based on the below sample, maybe you can tell if it's expected behaviour 😄

        FormBaseView(viewModel: viewModel) {
            view(for: viewModel.viewState)
                .id(viewModel.viewState)
                .transition(.opacity)
            Spacer()
        }

private func view(for viewState: ViewState) -> AnyView { 
.... //switch on viewState and return correct view
}

If I run a ViewInspector test on this, I get a very literal Tuple back saying the type was expected like this
FormBaseView<TupleView<(ModifiedContent<IDView<AnyView, ViewState>, _TraitWritingModifier<TransitionTraitKey>>, Spacer)>>

If I wrap the function call to my private view-function in an AnyView then it works

        FormBaseView(viewModel: viewModel) {
            AnyView(view(for: viewModel.viewState)
                .id(viewModel.viewState)
                .transition(.opacity))
            Spacer()
        }

But since that function is already returning an AnyView, it feels like I'm wrapping my code one extra time to satisfy the tests.
Would it be possible to somehow look at the outcome from a function like that, or is the solution to make sure it's wrapped in an AnyView.

from viewinspector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.