Giter VIP home page Giter VIP logo

Comments (8)

nrivard avatar nrivard commented on May 30, 2024 2

Awesome, thank you! This project is great by the way!

from viewinspector.

nalexn avatar nalexn commented on May 30, 2024 1

Should be fixed in v0.3.6

from viewinspector.

nrivard avatar nrivard commented on May 30, 2024 1

Indeed fixed, thank you! Feel free to close this issue.

from viewinspector.

nrivard avatar nrivard commented on May 30, 2024

An alternative is to make LabelKey (and TraitStorage etc.) also appear in elements.some. Not sure why they don't but I haven't fully familiarized myself with the inner workings here.

from viewinspector.

nalexn avatar nalexn commented on May 30, 2024

Hey @nrivard

How do you attach the accessibilityLabel in the code you're testing? I'd help me to troubleshoot faster, as the test I have for accessibilityLabel() succeeds and it's hard to compare the dumps

from viewinspector.

nalexn avatar nalexn commented on May 30, 2024

Yours dump:

▿ modifier : AccessibilityAttachmentModifier
      ▿ attachment : Optional<AccessibilityAttachment>
        ▿ some : AccessibilityAttachment
          ▿ properties : AccessibilityProperties
            ▿ plist : [TypedValueKey = Optional(AccessibilityValue(value: nil, description: Optional(Text(storage: Text.Storage.verbatim("123456789012"), modifiers: [])))), LabelKey = Optional(Text(storage: Text.Storage.verbatim("UPCA product code"), modifiers: [])), TraitsKey = AccessibilityTraitStorage(mask: AccessibilityTraitStorage.(unknown context at $7fff2c6c4d64).TraitSet(rawValue: 288), values: AccessibilityTraitStorage.(unknown context at $7fff2c6c4d64).TraitSet(rawValue: 288))]
              ▿ elements : Optional<Element>
                ▿ some : TypedValueKey = Optional(AccessibilityValue(value: nil, description: Optional(Text(storage: Text.Storage.verbatim("123456789012"), modifiers: []))))

The dump from the test in the framework:

modifier: AccessibilityAttachmentModifier
    ▿ attachment: Optional(AccessibilityAttachment.properties(AccessibilityProperties(plist: [LabelKey = Optional(Text(storage: Text.Storage.verbatim("abc"), modifiers: []))])))
      ▿ some: AccessibilityAttachment.properties
        ▿ properties: AccessibilityProperties
          ▿ plist: [LabelKey = Optional(Text(storage: Text.Storage.verbatim("abc"), modifiers: []))]
            ▿ elements: Optional(LabelKey = Optional(Text(storage: Text.Storage.verbatim("abc"), modifiers: [])))
              ▿ some: LabelKey = Optional(Text(storage: Text.Storage.verbatim("abc"), modifiers: [])) #0
                ▿ super: PropertyList.Element
                  - keyType: AccessibilityProperties.(unknown context at $7fff2c6b8688).LabelKey #1
                  - before: nil
                  - after: nil
                  - length: 1
                  ▿ keyFilter: BloomFilter
                    - value: 137439084544
                ▿ value: Optional(Text(storage: Text.Storage.verbatim("abc"), modifiers: []))
                  ▿ some: Text
                    ▿ storage: Text.Storage.verbatim
                      - verbatim: "abc"
                    - modifiers: 0 elements

These dumps have a different structure, meaning that the code for attaching the modifier, or something in the project's configs or even the Phone's accessibility settings is different. We need to find that first.

from viewinspector.

nrivard avatar nrivard commented on May 30, 2024

Here is my particular use-case:

    public var body: some View {
        UPCBarView(digits: upc.digits)
            .accessibility(addTraits: [.isImage, .isStaticText])
            .accessibility(value: Text(verbatim: upc.value))
            .accessibility(label: Text(upc.accessibilityLabel))
    }

Only the last modifier shows up in the elements path, so label succeeds and a query for value fails. If I switch label and value, then value succeeds and label will fail. Here is my test:

import XCTest
import ViewInspector
@testable import UPCPrinter

final class AccessiblityTests: XCTestCase {

    func testAccessilibity() throws {
        let value = "123456789012"
        let upc = try XCTUnwrap(UPCFactory.upc(from: value, verifyChecksum: false))

        let upcViewInspection = try UPCView(upc: upc).inspect().view(UPCBarView.self)
        XCTAssertEqual(try upcViewInspection.accessibilityLabel().string(), upc.accessibilityLabel)
        XCTAssertEqual(try upcViewInspection.accessibilityValue().string(), upc.value)
    }
}

from viewinspector.

nalexn avatar nalexn commented on May 30, 2024

Got it! Accessibility modifiers work in a bit different way in SwiftUI than the others. Usually, the modifiers form a stack of wrapped ModifiedContent structures, while Accessibility patch one ModifiedContent and even change the inner structure. I'll implement a patch shortly. Thank you for rasing the issue!

from viewinspector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.