Hi, there. As this is a "pure" usage / documentation question and not about a failure

Provider 2.0.0+ Import? about terraform-provider-namecheap HOT 4 CLOSED

namecheap commented on September 24, 2024

Provider 2.0.0+ Import?

from terraform-provider-namecheap.

Comments (4)

trilom commented on September 24, 2024

Looked at this today and found the following:

This line is where the issue happens:

terraform-provider-namecheap/namecheap/namecheap_domain_record.go

Lines 193 to 196 in 46977b8

 nsResponse, err := client.DomainsDNS.GetList(domain) 

 if err != nil { 

 return diag.FromErr(err) 

 }

It calls the GetList endpoint which calls ParseDomain

terraform-provider-namecheap/vendor/github.com/namecheap/go-namecheap-sdk/v2/namecheap/domains_dns_get_list.go

Lines 45 to 48 in 46977b8

 parsedDomain, err := ParseDomain(domain) 

 if err != nil { 

 return nil, err 

 }

The ParseDomain then throws an error

terraform-provider-namecheap/vendor/github.com/namecheap/go-namecheap-sdk/v2/namecheap/namecheap.go

Lines 154 to 156 in 46977b8

 if !regDomain.MatchString(domain) { 

 return nil, fmt.Errorf("invalid domain: incorrect format") 

 }

Based on logs from an import maybe the "domain" var passed to the API needs to be explicitly cast to a string. When import was originally implemented it used a different endpoint that as of 5 months ago runs the same ParseDomain

2021-12-27T07:25:24.598-0500 [TRACE] vertex "namecheap_domain_records.test (import id \"test.domain\")": visit complete

terraform-provider-namecheap/namecheap/resource_namecheap_record.go

Line 152 in b4de80c

 records, err := client.GetHosts(domainParts[len(domainParts)-2] + "." + domainParts[len(domainParts)-1]) 

from terraform-provider-namecheap.

StyleT commented on September 24, 2024

Hi!

Thanks for identifying the issue and PR! I'll take a look at it as soon as possible. But likely it's gonna happen somewhere next week or so...

from terraform-provider-namecheap.

StyleT commented on September 24, 2024

This was fixed in v2.1.0

from terraform-provider-namecheap.

ptous commented on September 24, 2024

A bit late on the response, but I wanted to confirm that the fixed import functionality works very well, pulling in state for all the records in a domain declared in the HCL. This allowed me to easily flesh out HCL that matched the domain's config based on plan differences. My domain configs weren't huge, but they were big enough that I wanted to codify them in case of loss, and this made that possible with confidence. You folks have my sincere thanks.

from terraform-provider-namecheap.

Recommend Projects

Provider 2.0.0+ Import? about terraform-provider-namecheap HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	nsResponse, err := client.DomainsDNS.GetList(domain)
	if err != nil {
	return diag.FromErr(err)
	}

	parsedDomain, err := ParseDomain(domain)
	if err != nil {
	return nil, err
	}

	if !regDomain.MatchString(domain) {
	return nil, fmt.Errorf("invalid domain: incorrect format")
	}