Giter VIP home page Giter VIP logo

Comments (10)

nanawel avatar nanawel commented on May 19, 2024 1

Hi, and thanks very much :)

Hopefully that should not be too hard indeed. I'll take a look very soon.

from our-shopping-list.

kungfoolfighting avatar kungfoolfighting commented on May 19, 2024 1

Works great now, thanks so much!

from our-shopping-list.

nanawel avatar nanawel commented on May 19, 2024

@kungfoolfighting The latest release 2.7.0 should now support what you need.

https://github.com/nanawel/our-shopping-list/releases/tag/2.7.0

If you're serving multiple instances on the same host, please read https://github.com/nanawel/our-shopping-list#-notes-when-serving-multiple-instances-on-different-web-roots

from our-shopping-list.

kungfoolfighting avatar kungfoolfighting commented on May 19, 2024

Oh wow, thanks a bunch for the super speedy implementation of this! Greatly appreciated. I will give it a try today.

from our-shopping-list.

kungfoolfighting avatar kungfoolfighting commented on May 19, 2024

I have tested this now and I can't quite get it to work with a reverse proxy.
When simply connecting to the server via the port and the base url like this:
http://myserver:port/osl/ it works flawlessly.
But when using a reverse proxy (nginx) with the following configuration:

    location /osl/ {
            proxy_set_header Accept-Encoding "";
            proxy_pass http://myserver:port;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
            proxy_http_version 1.1;
        }

It loads almost everything but doesn't show any boards.
The console shows:
chunk-vendors.59332c6d.js:1 GET http://myserver/boards/00000000-0000-0000-0000-000000000000 404 (Not Found)

So it is not using the base url for that specific request. Other requests do use the base url (for images and scripts etc.).
Any idea if I am doing something wrong, or is there still an issue with the feature?
Sorry for causing more work with this :(

from our-shopping-list.

nanawel avatar nanawel commented on May 19, 2024

Hi,
np, there might be some details missing even if I tried to cover all the possible cases.

You did not mention you set the BASE_URL in your container. Did you?
This is mandatory. If you're serving the app on a custom web root, you have to set this variable in your environment section:

services:
  app:
    image: ...
    ...
    environment:
      BASE_URL: '/osl/'

from our-shopping-list.

kungfoolfighting avatar kungfoolfighting commented on May 19, 2024

Oh yeah, sorry, I omitted mentioning that, since I thought the non-proxy version would not work at all with that url if I hadn't set the base url.

It looks like this:

    environment:
      # Default values below
      VUE_APP_I18N_LOCALE: en
      VUE_APP_I18N_FALLBACK_LOCALE: en
      VUE_APP_I18N_FORCE_LOCALE: 0
      VUE_APP_SINGLEBOARD_MODE: 1
      VUE_APP_LIST_ALL_BOARDS_ENABLED: 1
      BASE_URL: 'osl/'

from our-shopping-list.

kungfoolfighting avatar kungfoolfighting commented on May 19, 2024

Also small correction: since I am in single board mode I should have said "it doesn't list any lists" rather than "it doesn't list any boards".

from our-shopping-list.

nanawel avatar nanawel commented on May 19, 2024

Also small correction: since I am in single board mode I should have said "it doesn't list any lists" rather than "it doesn't list any boards".

You're right. There seems to be a bug with singleboard mode. Let me take a look.

from our-shopping-list.

nanawel avatar nanawel commented on May 19, 2024

That should be fixed now with 2.7.1. Tell me if it works as expected in your environment.

from our-shopping-list.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.