wrong -isystem /usr/include in pch.h compilations flags about cmakepchcompiler HOT 7 CLOSED

I dump all properties for Qt5::Gui and one from them:

Qt5::Gui INTERFACE_INCLUDE_DIRECTORIES = /usr/include/qt5/;/usr/include/qt5/QtGui;/usr/include

Also I opened CMake sources. They exclude /usr/include. https://github.com/Kitware/CMake/blob/master/Source/cmLocalGenerator.cxx#L964

from cmakepchcompiler.

@drizt Hi, thanks for the root cause analysis. Can you please let me know if removing /usr/include from Qt's INTERFACE_INCLUDE_DIRECTORIES fixes the problem? If yes, I believe it is Qt to be blamed not CMakePCHCompiler.
Apparently CMake there at https://github.com/Kitware/CMake/blob/master/Source/cmLocalGenerator.cxx#L964 hardcodes some bugfix, which is obviously not affecting CXXPCH & CPCH derived PCH languages.

from cmakepchcompiler.

Yes. For Qt5 I use such workaround:

  get_target_property(Qt5GuiIncDirs Qt5::Gui INTERFACE_INCLUDE_DIRECTORIES)
  list(REMOVE_ITEM Qt5GuiIncDirs "/usr/include")
  set_target_properties(Qt5::Gui PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${Qt5GuiIncDirs}")

And this for Qt4:

  get_target_property(Qt4GuiIncDirs Qt4::QtGui INTERFACE_INCLUDE_DIRECTORIES)
  list(REMOVE_ITEM Qt4GuiIncDirs "/usr/include")
  set_target_properties(Qt4::QtGui PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${Qt4GuiIncDirs}")

  get_target_property(Qt4CoreIncDirs Qt4::QtCore INTERFACE_INCLUDE_DIRECTORIES)
  list(REMOVE_ITEM Qt4CoreIncDirs "/usr/include")
  set_target_properties(Qt4::QtCore PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${Qt4CoreIncDirs}")

  list(REMOVE_ITEM QT_INCLUDE_DIR "/usr/include")

from cmakepchcompiler.

You use non-standard lang for pch header. It's very rare case. I think this problem can happens in other cases not only mine. Maybe this information should be add to README or there is a way to workaround it in your CMakePCHCompiler?

from cmakepchcompiler.

Open an issue on Qt bugtracker.

from cmakepchcompiler.

Okay, thanks for the update. Do you think we should keep this issue open or we can close it now?

from cmakepchcompiler.

This was very likely fixed by fa975ba and looks similar to #36, anyways the example in Tests/Issue36_QTFramework now works.

from cmakepchcompiler.