Giter VIP home page Giter VIP logo

Comments (11)

wimleers avatar wimleers commented on August 16, 2024

Looking at https://github.com/naofireblade/homebridge-weather-plus/blob/master/apis/weatherflow.js, I don't understand how it could ever get set to undefined by the actual Weatherflow plugin though:

  • line 311: that.currentReport.RainBool = true;
  • line 378: that.currentReport.RainBool = message.obs[0][3] > 0 ? true : false;
  • line 431: that.currentReport.RainBool = message.obs[0][12] > 0 ? true : false;

These are the only 3 lines modifying RainBool. So that suggests the bug lies in the overarching infrastructure? 🤔

from homebridge-weather-plus.

wimleers avatar wimleers commented on August 16, 2024

/cc @dacarson

from homebridge-weather-plus.

dacarson avatar dacarson commented on August 16, 2024

Looking at the debug information above, all the values are set to their defaults, so it seems that we have not received an initial set of data from the weather station. Which makes sense from your description - the battery is dead.
Looking through the set of initialization data in Weaatherflow.js, I see that RainBool is never set to a default value. A value is only set when a set of data is received. There is an easy fix, to initialize it.

I have the simple fix on my branch, as well as a number of other fixes. Can you remind me how to get the changes onto the main branch?
master...dacarson:homebridge-weather-plus:master

from homebridge-weather-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.