Comments (8)
I'd like to work on this issue, and have been thinking about it / looking around the dist for a few days.
brand/pages/pages is not a directory in the dist site-worldview, but brand/pages is. When I create the second page subdirectory (in my local apache2 var/www directory) as follows:
I get the following to show up at the mobile-sized browser link given above:
from worldview.
@Dylan-Brown Nice work. I'm glad you are taking on this issue. We have been meaning to get to it for some time now.
So, I don't think we need to necessarily alter the location of the template. The base of the issue appears to be that in mobile devices the about page opens in a new window and that with higher resolution screens the about page opens as a pop-up/modal.
https://github.com/nasa-gibs/worldview/blob/master/web/js/ui/wv.ui.info.js#L79-L92
You should be able to solve this by just fixing the href in the template file:
https://github.com/nasa-gibs/worldview-options-eosdis/blob/master/common/brand/pages/about.html#L145
I found another link that is broken in the same template:
https://github.com/nasa-gibs/worldview-options-eosdis/blob/master/common/brand/pages/about.html#L170
from worldview.
So, I rebased my fork after seeing there were two new contributions... and now I can't seem to find about.html anywhere. The folder brand/pages doesn't exist; in brand, there's just .gitignore and .htaccess files?
from worldview.
That's located in https://github.com/nasa-gibs/worldview-options-eosdis/tree/master/common/brand/pages
from worldview.
@Dylan-Brown I think I closed it a bit soon. It doesn't work on localhost when the URI points to the live instance of Worldview. So keeping this issue open for now
from worldview.
@tgunnoe so, should I change the links to relative directories? For instance,
< a href='../../pages/worldview-opensourcelibs.html' target='_blank'>open source projects.
?
Since the 'about.html' file is in the options directory, I wasn't sure how changing it would affect an unpacked dist.
from worldview.
you can also open it in a modal under Info -> About in Worldview on the desktop. The absolute link works in both now on production but you'd want to see local changes of it in your local environment.
So a "../../pages" relative wouldnt work. "@hostname@/pages" or something similar would be ideal
from worldview.
This is no longer relevant after nasa-gibs/worldview-options-eosdis#147
(That update has not been deployed yet, but will automatically be included in the next deployment of Worldview)
from worldview.
Related Issues (20)
- Add caveat to NOAA-20/VIIRS CR and TB layer descriptions
- Vector tile preloading issues HOT 3
- Investigate cross-fading tiles on time step HOT 1
- Tour animate function needs updating
- [DEVELOP] Error changing date when coordinate location marker is present HOT 4
- Add GOES-West caveat to description HOT 2
- add L30 to step one of HLS tour story
- Add SSEC VIIRS NOAA-20 Cloud prop HOT 1
- [DEVELOP] If B tab is selected and you exit comparison, map date should match B tab date.
- Update number of imagery layers to over 1000 HOT 2
- update VIIRS/NOAA-20 cloud descriptions for new layout
- Tooltip delay hangs too long over timeline buttons
- Update intro to WV tour story to include "today" button
- Tour step retains custom palette values
- [compare.mobile.init.2]: "B" comparison date is not 7 days before "A" date when coming from a saved URL
- Node: cannot execute binary file HOT 1
- You have a bug in the map view HOT 4
- Manual?? HOT 1
- UX issue: Close button and external link button overlapping on mobile
- Acessing the Suomi/NPP VIIRS True Color Corrected Reflectance product HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from worldview.