Giter VIP home page Giter VIP logo

Comments (5)

Omkar20895 avatar Omkar20895 commented on May 28, 2024

@lewismc I am checking out the files and will identify the issues. Thanks.

from podaacpy.

Omkar20895 avatar Omkar20895 commented on May 28, 2024

@lewismc the first error is for the remove statements, remember we were cleaning up the data downloaded by the test cases? using os.remove().

Coming to the second and third errors, they are on file open and read used in setu.py and mcc.py, I can't find the vulnerability here, but we can discuss on this. Thanks.

from podaacpy.

lewismc avatar lewismc commented on May 28, 2024

@lewismc the first error is for the remove statements, remember we were cleaning up the data downloaded by the test cases? using os.remove().
Yes but 'maybe' there is a better way to do it! Honestly, right now I don't know. I think we need a GHangout to decide.

Coming to the second and third errors, they are on file open and read used in setu.py and mcc.py, I can't find the vulnerability here, but we can discuss on this. Thanks.

OK, well the difference between 'our' current checks and 'their's is important. If possible we should address. ... Only if possible. possibly via unit tests. OK

Anyway's, please just tell me how and if you were able to address. This is NOT a major deal, your branch needs to be addressed, updated and smartened up in order for it to be useful.

Please, please, please, can you write some unit tests. Can you log the issues you find at the OCW Issue tracker and please keep the way you are going.

OCW will benefit VERY well from having a PO.DAAC data source. Please take the above as positive criticisms and I will work with you ofline to resolve theh @Omkar20895

Thank you

from podaacpy.

Omkar20895 avatar Omkar20895 commented on May 28, 2024

@lewismc shall we discuss this??

from podaacpy.

lewismc avatar lewismc commented on May 28, 2024

Based on the fact that the API is essentially changing, I am closing this off.

from podaacpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.