Comments (5)
@lewismc I am checking out the files and will identify the issues. Thanks.
from podaacpy.
@lewismc the first error is for the remove statements, remember we were cleaning up the data downloaded by the test cases? using os.remove().
Coming to the second and third errors, they are on file open and read used in setu.py and mcc.py, I can't find the vulnerability here, but we can discuss on this. Thanks.
from podaacpy.
@lewismc the first error is for the remove statements, remember we were cleaning up the data downloaded by the test cases? using os.remove().
Yes but 'maybe' there is a better way to do it! Honestly, right now I don't know. I think we need a GHangout to decide.Coming to the second and third errors, they are on file open and read used in setu.py and mcc.py, I can't find the vulnerability here, but we can discuss on this. Thanks.
OK, well the difference between 'our' current checks and 'their's is important. If possible we should address. ... Only if possible. possibly via unit tests. OK
Anyway's, please just tell me how and if you were able to address. This is NOT a major deal, your branch needs to be addressed, updated and smartened up in order for it to be useful.
Please, please, please, can you write some unit tests. Can you log the issues you find at the OCW Issue tracker and please keep the way you are going.
OCW will benefit VERY well from having a PO.DAAC data source. Please take the above as positive criticisms and I will work with you ofline to resolve theh @Omkar20895
Thank you
from podaacpy.
@lewismc shall we discuss this??
from podaacpy.
Based on the fact that the API is essentially changing, I am closing this off.
from podaacpy.
Related Issues (20)
- Update release management policy to use twine HOT 6
- Python 2.6 master build failing HOT 2
- Implement Level3 and Level4 subsetting logic HOT 14
- Maintain directory structure when downloading from PODAAC Drive
- Augment Drive.download_granules with 'root' parameter HOT 1
- Function "mine_drive_urls_from_granule_search()" Returns Empty List HOT 3
- Refactor for the deprecation of FTP? HOT 10
- Question about granule_search() from web services API HOT 4
- Replace xml.etree.ElementTree.fromstring functions with their defusedxml equivalents. HOT 3
- Implement integration tests for drive.py HOT 2
- Accessing CYGNSS L0 data with podaacpy HOT 9
- Add support for Remote Sensing Systems (RSS) HTTP data access HOT 1
- Add PodaacUtils.mine_drive_urls_from_granule_search function
- drive.Drive(file) attempts to read from erroneous 'tests' directory
- Change root branch from master to main HOT 1
- PodaacUtils().list_all_available_extract_granule_dataset_ids() returns None HOT 1
- Port to Rust and Expose Crate and FFI Python Module HOT 3
- Working with proxy HOT 2
- Error in the example file "Using Podaacpy to retrieve CYGNSS Level 3 Science Data.ipynb" HOT 2
- Create public archive for Podaacpy
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from podaacpy.