Comments (4)
Seems reasonable. I think I'll submit a PR in a day or two.
from poethepoet.
Yes the approach is good.
And here's a pre-release for your efforts! https://pypi.org/project/poethepoet/0.11.0b6/
from poethepoet.
Hi @tsimoshka, I see how that could be useful. I'd be hesitant to add another option as a variation on an existing one, but we could make this one also accept other values as a non-breaking change.
Maybe something like:
ingore_fail = "return_non_zero" # makes it return
or
ingore_fail = "return_zero" # equivalent to true
This would require adding a validation condition that enforces that if it's a string then it's one of the known values.
I'm focused on other features for the moment, so if you create a PR (including updates to docs and test) then that would certainly help make this a reality sooner.
What do you think?
from poethepoet.
@nat-n, PR is ready, take a look when you have time.
I had to update type annotations for the __options__
in base task and all subclasses to keep mypy happy and be able to parse bool and str ignore_fail
option. Not sure if this is a right approach.
from poethepoet.
Related Issues (20)
- Doesn't respect environment over .env file HOT 6
- Poe breaks when directory has spaces in the name HOT 2
- Hooks with "private" tasks HOT 2
- Can't use os.path.isdir in case HOT 1
- Is is possible to overide the .envfile?
- typo in docs HOT 1
- Combination of `click` and `switch` command in `poe`
- No way to pass free arguments to a specific place HOT 2
- README links to localhost HOT 1
- Can't in-lined tasks from another file with cwd HOT 4
- Included task envfile doesn't consider cwd HOT 7
- Breaking change (`0.21.1` -> `0.22.0`): Unable to reference sibling task files HOT 2
- sequence ignores dependencies of its steps HOT 2
- Commands are echoed without quotation marks in the log HOT 3
- Will poethepoet delete the virtual environment in poetry? HOT 2
- envfile on Windows is opened with ANSI code page HOT 2
- Commands flags with quoted parameters lose flags. HOT 2
- Tasks run in the current directory by default HOT 3
- Can't run task that `uses` a `switch` task HOT 2
- Duplicate SIGINT sent to suprocess on Unix based systems HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poethepoet.