Question/proposal: ignore_fail=true and final exit status of the task sequence about poethepoet HOT 4 CLOSED

Seems reasonable. I think I'll submit a PR in a day or two.

from poethepoet.

Yes the approach is good.

And here's a pre-release for your efforts! https://pypi.org/project/poethepoet/0.11.0b6/

from poethepoet.

Hi @tsimoshka, I see how that could be useful. I'd be hesitant to add another option as a variation on an existing one, but we could make this one also accept other values as a non-breaking change.

Maybe something like:

ingore_fail = "return_non_zero" # makes it return

or

ingore_fail = "return_zero" # equivalent to true

This would require adding a validation condition that enforces that if it's a string then it's one of the known values.

I'm focused on other features for the moment, so if you create a PR (including updates to docs and test) then that would certainly help make this a reality sooner.

What do you think?

from poethepoet.

@nat-n, PR is ready, take a look when you have time.

I had to update type annotations for the __options__ in base task and all subclasses to keep mypy happy and be able to parse bool and str ignore_fail option. Not sure if this is a right approach.

from poethepoet.