Comments (5)
Curiously in your last example the ()
are not encoded...
I think I can go with a relatively straightforward encode strategy since we expect the entire file path to be treated as the path
component from the URI spec.
- Allow unreserved characters
- Allow
/
unescaped - Escape all other characters. Expect that all characters are ascii
My first approach for decoding will probably only handle %nn
style encodings. Handling other cases like translating +
to space or %%
to %
could be trickier since it's less general.
from vim-lsc.
Can you try updating to the latest and see if it works for you?
from vim-lsc.
Hello @natebosch ,
Thank you for the update, looks good.
URI encoding for messages like textDocument/definition
or textDocument/didOpen
appears to be working, but there is one case (I found so far) where URI encoding does not get applied:
{"method":"initialize","jsonrpc":"2.0","id":1,"params":{"rootUri":"file:///Users/tester/projects/Sforce - SFDC Experiments/SForce (lsc-test)/src/classes","capabilities":{...}}
I think this line:
\ 'rootUri': 'file://'.getcwd(),
should look something like like this:
\ 'rootUri': lsc#uri#documentUri(getcwd()),
Curiously in your last example the () are not encoded...
that's my bad. Thank you for highlighting this.
from vim-lsc.
Good catch on the rootUri. Should be fixed now.
from vim-lsc.
That's great, thank you.
from vim-lsc.
Related Issues (20)
- pyright and Viewing Source Code Definition HOT 1
- perl LS?
- Error Unknown function lsc#cursor#insertEnter is thrown whenever entering in INSERT mode HOT 1
- Errors wit python-language-server
- Make vim-lsc work with ltex-ls HOT 6
- call hierarchy support? HOT 1
- support filtering trigger characters HOT 1
- LSClientRename renames wrong locations when it's across files HOT 1
- gopls: is there a way to specify settings? buildFlags or env? HOT 1
- Add support for CompletionItem additionalTextEdits
- Underline instead of highlight? HOT 1
- :wqa causes waiting for language server exit HOT 4
- javascriptreact filetype not running lsc HOT 2
- Do we have virtual text support for lsp diagnostics?
- Unable to get tailwindcss-language-server to work HOT 1
- No highlighting using a non-default colour scheme HOT 2
- Add a separate highlight group for deprecated diagnostics and unnecessary code
- Deno lsp not working HOT 1
- Completion preview/popup extra information filetype highlight?
- Support code sections within structured text documents (Markdown, etc)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vim-lsc.