Giter VIP home page Giter VIP logo

Comments (7)

nathanieljohnston avatar nathanieljohnston commented on September 26, 2024

Actually, I'm even having trouble just with inputParser right now. When running the script, I get the following error:

Undefined function 'addParameter' for input arguments of type 'inputParser'.

Error in LocalDistinguishability (line 63)
addParameter(parser, 'P', ones(1,num_ops)/num_ops, @isnumeric);

I get this in MATLAB 2011b as well as 2013a. Thoughts?

from qetlab.

cosenal avatar cosenal commented on September 26, 2024

I made another PR to fix that. Stupid MATLAB legacy issues. http://www.mathworks.com/help/matlab/ref/inputparser.addparamvalue.html
'Not recommended' (shrug)

from qetlab.

nathanieljohnston avatar nathanieljohnston commented on September 26, 2024

Thanks! The glitch is actually my fault -- in low-dimensional cases, the SymmetricExtension function did some simplifying stuff to speed up the script. However, that simplifying stuff assumed that the input state was positive semidefinite. Since your SDP never explicitly forced the measurements to be PSD, it was returning non-PSD "measurements" that gave higher values. I'll patch the SymmetricExtension function to fix this.

from qetlab.

nathanieljohnston avatar nathanieljohnston commented on September 26, 2024

Patch uploaded, and your code returns 5/6 now, as expected.

from qetlab.

cosenal avatar cosenal commented on September 26, 2024

Should I add an extra-constraint to check that the measurement operators are positive? or the SymmetricExtension function takes care of it in all cases now?

from qetlab.

nathanieljohnston avatar nathanieljohnston commented on September 26, 2024

The SymmetricExtension function takes care of it in all cases now: you don't need to change your function at all.

from qetlab.

cosenal avatar cosenal commented on September 26, 2024

Ok, thanks!

from qetlab.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.