Border attribute is not taken into account when calculating height about plugins HOT 13 CLOSED

@maicolsantos I realize you're from Fortaleza, aren't you? I've just moved from France to Juazeiro do Norte, what a coincidence!

from plugins.

@jsamr I sent you an email. 🤓

from plugins.

the following code snippet works to me, for now.
I'm waiting for an official fix.

alterChildren={(node) => {
  if (node.name === 'table') {
    node.attribs._rawHtml = node.attribs._rawHtml.replace(/border="\d+"/g, '')
  }
}

from plugins.

@thijs-qv @maicolsantos This is likely a box-sizing issue.

Can you try to add a CSS rule for the table element as such, and tell me if the issue disappear?

table {
  box-sizing: border-box;
}

from plugins.

I've added the rule to css-rules.js, but the issue still persists.

from plugins.

OK. Please provide me a minimal reproducible example (ideally, a git), and I'll be happy to investigate.

from plugins.

I've placed a simple example here.
Would be great if you can take a look.

from plugins.

@thijs-qv @maicolsantos This is my understanding of the issue so far:

1. The border table attribute is a legacy from old HTML specs, and is not part of the HTML 5 standard anymore.
2. The border table attribute is ignored when my script computes table's height because it uses, for best browser support, the scrollHeight.

I could probably just add the style's borderWidth value to the scrollHeight and it should fix the problem, if and only if browser engines transfer the legacy border property to the style object, which you will have to confirm.

I will publish pre-release patches that you can test, until the issue is resolved. Will keep you updated.

from plugins.

Thanks for looking into it. I'm not sure if adding the borderWidth to the scrollHeight will solve the issue. The border attribute specifies if a border should be displayed around the table cells or not. So it's not just the table that gets a border, but the cells as well.

from plugins.

@thijs-qv I don't think that is an issue because inner borders will be taken into account in scrollHeight. It did work on your MWE. Please test again with 0.5.1-rc.0, and let me know :-)

from plugins.

@jsamr You are correct, that is not an issue, it's working well now. Thank you / merci beaucoup!

from plugins.

@thijs-qv You're very welcomed!

from plugins.

@jsamr it's working well now. Thank you 🤓

from plugins.