Endless loop - EM release machine -> unbind -> reconnect about nats.rb HOT 5 CLOSED

Hi @krumts , thanks for super detailed investigation and summary of issue, this helped a lot.
Seems the combination of infinite reconnects (:max_reconnect_attempts: -1) and uncaught exceptions is making the client get stuck trying to reconnect without backing off each time, and agree that should be handled more gracefully.

Have a branch in the works where the client would not get stuck as in this case, so that the exception is raised instead, let me know if you have any feedback too. Thanks!
https://github.com/nats-io/ruby-nats/compare/time-based-reconnect-backoff

from nats.rb.

Hi @wallyqs , thanks for the quick reply! Nice to see that the investigation was helpful.
I tried running my test locally with the changes in client.rb, and the endless loop did not appear again.
However, I just had a look at the changes, and believe there is one error in the condition here:
https://github.com/nats-io/ruby-nats/compare/time-based-reconnect-backoff#diff-ef391b2fe211800bc221ab248b46db86R819
As it is now, both the if and else blocks return true.
If I understand the code properly, in case the if condition is fulfilled (time since last reconnect is greater than the configured one?), then false should be returned, meaning no delay is needed. Is this so?

Thanks again!

from nats.rb.

good catch, that's definitely a bug... 😓
thanks for taking a look!

from nats.rb.

@krumts Fix is in master and will prepare a release including the change soon, thanks again.

from nats.rb.

@krumts pushed earlier a version of the gem which has this fix now: https://rubygems.org/gems/nats/versions/0.8.2

from nats.rb.