nodata returning as NaN about node-gdal HOT 6 CLOSED

What raster file are you using to test it?

I get the same result as you when calling getNoDataValue() on samples/example.tif, but that is because there isn't any no-data value set for that raster.

It seems to be working fine for me if I try it with a raster that has a no-data value set.

from node-gdal.

I am using node-gdal/examples/sample.tif and a LANDSAT 7 image I downloaded from Earth Explorer. I just downloaded another and I did get a number value -1000000000 for nodata.

Thanks for your response!

from node-gdal.

@brandonreavis Would it be possible to return null instead of NaN in this situation?

from node-gdal.

@GretaCB Great minds think alike haha. I changed that about an hour ago and am about to push the changes and post it to this thread.

I'm in the midst of cleaning up RasterBand objects now. getNoDataValue() will change to become an attribute so you can get it by just writing band.noDataValue.

Hopefully in the next day or two we will have the API more in its final state so you won't have to keep changing your scripts. Thanks for testing things out!

from node-gdal.

Awesome @brandonreavis :) thanks! And if you need help with writing tests, and getting things squared away on the javascript side, let me know! I can actually start picking away at some tests tonight/tomorrow if that will help.

I'm assuming the functions in the .cpp classes are the ones that need tests? For example: https://github.com/naturalatlas/node-gdal/blob/9d63fd6baf896fcf8067c2ec1d2b864a10156496/src/gdal_rasterband.cpp#L18-56

from node-gdal.

Alright will do! Thanks! @brianreavis knows more than I do about where we are with writing tests.

Probably the best thing to do at the moment is to look over the documentation and see if anything else seems awkward or missing (like the color interpretation thing). That's been a great help!

from node-gdal.