Giter VIP home page Giter VIP logo

Comments (7)

DrHolzer avatar DrHolzer commented on May 23, 2024

OK, I found the solution and I am posting it here for everyone's benefit. Plus I may need to find this again when I try to update homebrewery in the future.

In package.json I changed:

  "engines": {
    "node": "16.11.x"
  },

to:

  "engines": {
    "node": "16.13.x"
  },

In Dockerfile I changed:

FROM node:16.11-alpine

to:

FROM node:16.13-alpine

Everything compiled and is up and running.

from homebrewery.

G-Ambatte avatar G-Ambatte commented on May 23, 2024

Got it - this commit changes the npm version from 8.10.0 to 9.6.2, which is incompatible with node version 16.11.x.

The problem is that @DrHolzer is running the cutting edge master branch, which includes the above dependency-bump PR which breaks everything - we'll either need to bump node to 16.13.x everywhere (including Docker), or keep npm to 8.10.0 (or whatever the latest working version is).

from homebrewery.

G-Ambatte avatar G-Ambatte commented on May 23, 2024

Re-opening issue to address build failures.

from homebrewery.

DrHolzer avatar DrHolzer commented on May 23, 2024

I an running it in Docker and everything seems to work fine. Is there something specific I can test for you to see if it breaks? Happy to help.

from homebrewery.

rjbprime avatar rjbprime commented on May 23, 2024

Just tried to use the docker image myself, got the following error:

docker-compose up -d
[+] Running 1/1
 ! homebrewery Warning                                                                                                         3.1s
[+] Building 69.2s (9/11)
 => [internal] load build definition from Dockerfile                                                                           0.0s
 => => transferring dockerfile: 32B                                                                                            0.0s
 => [internal] load .dockerignore                                                                                              0.0s
 => => transferring context: 34B                                                                                               0.0s
 => [internal] load metadata for docker.io/library/node:16.13-alpine                                                           0.9s
 => [internal] load build context                                                                                              0.1s
 => => transferring context: 23.41kB                                                                                           0.1s
 => [1/7] FROM docker.io/library/node:16.13-alpine@sha256:2f50f4a428f8b5280817c9d4d896dbee03f072e93f4e0c70b90cc84bd1fcfe0d     0.0s
 => CACHED [2/7] RUN apk --no-cache add git                                                                                    0.0s
 => CACHED [3/7] WORKDIR /usr/src/app                                                                                          0.0s
 => CACHED [4/7] COPY package.json ./                                                                                          0.0s
 => ERROR [5/7] RUN yarn install --ignore-scripts                                                                             68.1s
------
 > [5/7] RUN yarn install --ignore-scripts:
#0 0.666 yarn install v1.22.15
#0 0.719 info No lockfile found.
#0 0.727 [1/5] Validating package.json...
#0 0.731 [2/5] Resolving packages...
#0 19.90 warning npm > node-gyp > make-fetch-happen > cacache > @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
#0 26.90 warning [email protected]: Please upgrade to v7.0.2+ of superagent.  We have fixed numerous issues with streams, form-data, attach(), filesystem errors not bubbling up (ENOENT on attach()), and all tests are now passing.  See the releases tab for more information at <https://github.com/visionmedia/superagent/releases>.
#0 26.98 warning superagent > [email protected]: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
#0 34.90 warning vitreum > watchify > [email protected]: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
#0 35.63 warning vitreum > browserify > url > [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
#0 35.86 warning vitreum > watchify > chokidar > [email protected]: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
#0 37.08 warning vitreum > watchify > chokidar > braces > snapdragon > [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
#0 37.28 warning vitreum > watchify > chokidar > braces > snapdragon > source-map-resolve > [email protected]: See https://github.com/lydell/source-map-url#deprecated
#0 37.46 warning vitreum > watchify > chokidar > braces > snapdragon > source-map-resolve > [email protected]: https://github.com/lydell/resolve-url#deprecated
#0 38.02 warning vitreum > watchify > chokidar > braces > snapdragon > source-map-resolve > [email protected]: Please see https://github.com/lydell/urix#deprecated
#0 47.02 [3/5] Fetching packages...
#0 67.64 error [email protected]: The engine "node" is incompatible with this module. Expected version ">=16.14". Got "16.13.2"
#0 67.65 error Found incompatible module.
#0 67.65 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
------
failed to solve: executor failed running [/bin/sh -c yarn install --ignore-scripts]: exit code: 1

After following @DrHolzer's example of updating the required node in both the packages.json and Dockerfile, it seems to have built the docker image. Seems to load fine, will give it a try now.

from homebrewery.

rjbprime avatar rjbprime commented on May 23, 2024

After testing it, it doesn't render the content in the preview window. Using MS Edge v. 112.0.1722.34 (Official build) (64-bit) nor Chromium v. 112.0.5615.50 (Official Build) (64-bit). Could this be looked at?


Edit: a page refresh and clicking the "Create New" button on the landing page seems to bring up the page render preview. 😖

from homebrewery.

calculuschild avatar calculuschild commented on May 23, 2024

@rjbprime I have a suspicion about why the preview window isn't loading right away. I believe one of our dependencies is causing a conflict when first loading the brew renderer. I can see if there is a workaround.

from homebrewery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.