Print view doesn't include the Language Attribute about homebrewery HOT 7 OPEN

Good catch, should have thought of adding lang attribute to print too, we'll be right on it.

from homebrewery.

That Pull Request adds in the fix by setting the lang attribute on the div.pages element, which is high enough in the DOM to work and low enough to be accessed easily in the current configuration of the page.

from homebrewery.

Very nice, and looks like it was even a relatively simple fix - many thanks!

Just one thing (from just a cursory glance, so I might very well be wrong here): the current default value for the lang attribute seems to be en as opposed to en-US (though that was located in a different part of the repo). Maybe that ought to be adjusted accordingly?

from homebrewery.

Actually no, as defined by W3C, lang codes in html do not include the country.

https://www.w3.org/International/O-help-lang.html

from homebrewery.

Ah! To clarify my words, perhaps the en-US should have been changed to en - looks like you made the change already.

from homebrewery.

Actually no, as defined by W3C, lang codes in html do not include the country.

https://www.w3.org/International/O-help-lang.html

That's a very old reference. More recent specs make mention of country and dialect variations.

https://www.w3.org/International/questions/qa-html-language-declarations

from homebrewery.

According to that spec:

BCP 47 incorporates, but goes beyond, the ISO sets of language and country codes. To find relevant codes you should consult the IANA Language Subtag Registry.

Checking that:

So, no country codes anyway.

from homebrewery.