inconsistency in the scaling of the y-axes about billboard.js HOT 4 OPEN

@michkami
When there're 2 or more values aligned to single axis(y or y2), the domain range will set according it.

Let's say, given values are 300 and 500, in this case, min=300 and max=500.
But when single value (ex. 500) is given, can't determine min/max, because there's no data to determine or compare.

So, in this case min will be set as 0 and max 500.
https://github.com/naver/billboard.js/blob/master/src/ChartInternal/internals/domain.ts#L136

from billboard.js.

@michkami When there're 2 or more values aligned to single axis(y or y2), the domain range will set according it.

Let's say, given values are 300 and 500, in this case, min=300 and max=500. But when single value (ex. 500) is given, can't determine min/max, because there's no data to determine or compare.

So, in this case min will be set as 0 and max 500. https://github.com/naver/billboard.js/blob/master/src/ChartInternal/internals/domain.ts#L136

I see, this makes sense.

Maybe not completely connected to the question above, but I found this line here

Do you see any reason to not add an exception for the 0 values here?

In this case I would expect the zerobased option to still be working:
https://jsfiddle.net/michkami/6vr1z20f/

from billboard.js.

Do you see any reason to not add an exception for the 0 values here?

The conditional stayed from the start of the project and maintained as, mainly to not break any possible issue.
https://github.com/naver/billboard.js/blob/1.0.0/src/internals/domain.js#L156

from billboard.js.

The conditional stayed from the start of the project and maintained as, mainly to not break any possible issue. https://github.com/naver/billboard.js/blob/1.0.0/src/internals/domain.js#L156

Yes, I saw this. My question was if there it would be possible to add 0 as an exception here in case zerobased is true, so that the y axis will start on the x axis level when min is set to 0.

The current behaviour is what i would only expect if I set zerobased: false and then set the min value to 0.
If zerobased: true and I set the y axis min to 0, I would expect for it to start at the same level as the x axis.
I played around and saw, that if i pass null to y axis min, it would in this case work as expected, but the types only accept number | undefined.

from billboard.js.