code not portable and not robust about navit HOT 7 CLOSED

Logged In: YES
user_id=1071930
Originator: NO

Thanks for your hints.
Any patches for navit to make it work on BSD would be welcome.

Regards,

Original comment by: martin-s

from navit.

patch for posix potability

Original comment by: diekhans

from navit.

Logged In: YES
user_id=66101
Originator: YES

Attached is a patch that will allow navit to compile on FreeBSD 6.2 and probably fixes most posix portability
problems.

Note that by defining _LARGEFILE_SOURCE,
you don't need to call fopen64. I can't remember if this applies to the O_LARGEFILE to open, so I just added #define magic.

This doesn't fix everything, just the compile problems. There are still multiple warnings that should be fix. The program tries to execute pidof, which is not a posix program and not available on freebsd. The lack of error checking is a show stopper and doesn't make it worth tracking down the other problems:

Running from source directory
pidof: not found
navit:vehicle_new:enter
navit:vehicle_new:source='gpsd://localhost' type='gpsd'
navit:vehicle_new:invalid type

** (process:51437): WARNING **: failed to instantiate gui '(null)'

Using 'navit.xml'
No instance has been created, exiting

best wishes,
Mark
File Added: posix.patch

Original comment by: diekhans

from navit.

Logged In: YES
user_id=1071930
Originator: NO

Thanks for your patch, it is applied to cvs now
You can ignore the pidof error, pidof is just used for a special purpose on pda application.
The rest looks like the plugins don't get loaded. Does BSD have something like strace to find out why?
You can also try using the newest cvs version with the configure switch --disable-plugins which compiles everything as a static library and links it in at compile time.

Regards,

Original comment by: martin-s

from navit.

• status: open --> closed-fixed

Original comment by: kazer_

from navit.

Logged In: YES
user_id=1700563
Originator: NO

And patch was applied, so we can close this ticket. Thanks for your help.

Original comment by: kazer_

from navit.

Logged In: YES
user_id=1700563
Originator: NO

A few months ago, we moved our bugtracker to http://trac.navit-project.org.

We understand that it might be more convenient to use SF's bugtracker, but it lacks some features like milestones.

So please update your bookmarks. Accounts on the new bugtracker have to be manually created currently, but they are open to everyone. Please have a look at the tracker homepage.

Thank you for your interest in navit.

Original comment by: kazer_

from navit.