Giter VIP home page Giter VIP logo

Comments (5)

gothub avatar gothub commented on August 22, 2024

All issues identified by devtools::check() have been resolved except for:

  • checking R code for possible problems ... NOTE
    community_stability: no visible binding for global variable ‘stability’

This looks like a simple problem from community_stability.R, line 19, maybe one of the
authors could fix this.

Also, running check on Max OSX (I'm on 10.9.5) produces this error:

  • checking PDF version of manual ... WARNING
    LaTeX errors when creating PDF version.
    This typically indicates Rd problems.
    LaTeX errors found:
    ! LaTeX Error: File `inconsolata.sty' not found.

This appears to be an error with the library 'texinfo @5.2.2' that is incompatible with R, and has been an issue for awhile. This error does not occur on Ubuntu 14.04, so this appears to be an issue with R and
not the codyn package. If you are interested, the problem is described here:

http://markmail.org/search/?q=list%3Aorg.r-project.r-devel+inconsolata.sty#query:list%3Aorg.r-project.r-devel%20inconsolata.sty+page:1+mid:arxwlgn5jkvzpibd+state:results

from codyn.

jarioksa avatar jarioksa commented on August 22, 2024

Actually, R CMD check --as-cran gives three new NOTEs which all are easy to fix.

In the first case check even gives the solution: capitalize initial letters

The Title field should be in title case, current version then in title case:
‘Community dynamics metrics’
‘Community Dynamics Metrics’

Second is more cryptic: you have to mean that in R "complete sentence" means any string ending with full stop (period). See https://stat.ethz.ch/pipermail/r-help/2015-July/430057.html . This also got into Twitter.

* checking DESCRIPTION meta-information ... NOTE
Malformed Description field: should contain one or more complete sentences.

These were old things, but new R also wants you to explicitly import packages in stats, graphics etc. Fortunately the new check also gives you the text you need to add to your NAMESPACE:

Undefined global functions or variables:
  aggregate as.formula cor cov lm quantile sd stability var
Consider adding
  importFrom("stats", "aggregate", "as.formula", "cor", "cov", "lm",
             "quantile", "sd", "var")
to your NAMESPACE.

This adds several new unknown names in addition to stability.

The coding of stability is really opaque, though. I had to look code for a long time before noticing that you referred to a column in output. I would consider more transparent coding.

Please do not use is.na(stability) == F but use instead !is.na(stability).

from codyn.

mbjones avatar mbjones commented on August 22, 2024

Fixed all issues with non-ASCII characters in doc files.

from codyn.

mbjones avatar mbjones commented on August 22, 2024

Confirmed that all checks are working on:

  • Mac OS X 10.3.3, R 3.2.2
  • Debian, R 3.2.2
  • Debian, R-devel
  • Windows, R 3.2.2
  • Windows, R-devel

from codyn.

mbjones avatar mbjones commented on August 22, 2024

All checks resolved.

from codyn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.