Comments (9)
cc: @nearmax
it would be nice to have the option for all members to be on one line and only wrap starting at method's.
- message.body
- .parents
+ message.body.parents
.into_iter()
.filter(|h| !self.dag.expect(UNINITIALIZED_DAG_ERR).contains_message(&h))
.collect();
relevant discussion and links:
rust-lang/rustfmt#3210
rust-lang/style-team#66
rust-lang/style-team@bec533c
this is not possible with rustfmt and it seems like they are opposed to adding the option
from nearcore.
The linter gets quite terrible:
https://gitlab.com/nearprotocol/nearcore/-/jobs/123228836
If we want linter and it does not allow us to turn this wrapping off then we should disable the linter and fork it. This should not be blocking us
- let (v0,v1,v2,v3,v4,v5,v6,v7,v8,v9,v10,v11,v12,v13,v14,v15,v16,v17,v18,v19,v20,v21,v22,v23);
+ let (
+ v0,
+ v1,
+ v2,
+ v3,
+ v4,
+ v5,
+ v6,
+ v7,
+ v8,
+ v9,
+ v10,
+ v11,
+ v12,
+ v13,
+ v14,
+ v15,
+ v16,
+ v17,
+ v18,
+ v19,
+ v20,
+ v21,
+ v22,
+ v23,
+ );
from nearcore.
@azban we are ok with clippy / cargo fmt for now?
from nearcore.
Seems clipply disabled on nightly. I'd prefer to get it back
from nearcore.
Last time I checked clippy did not compile on CI because of the nightly switch.
from nearcore.
@bowenwang1996 fixed that in #675
i'm fine with clippy.. we still haven't converged on cargo fmt for linting, and i feel like it would be a good idea to have a strict formatting tool to use at some point
from nearcore.
I disabled clippy again due to its instability with nightly. On some days it work with nightly and when we are not lucky, it doesn't.
from nearcore.
@azban I am fine with rustfmt. Sometimes it derps, but it seems to be the widely accepted standard and we should be using at least something, so let's use it.
from nearcore.
Closing this, as we have now CI check.
from nearcore.
Related Issues (20)
- Tracking issue for fixing minimal required stake HOT 2
- [Epoch Sync] Blocks received during state sync marked as invalid
- mainnet: synced node has regular Downloading blocks logs HOT 3
- [ReshardingV3] Receipts Reassignment HOT 1
- [EpochSync] Defend against malicious peers sending invalid epoch sync
- Difficulties Managing Gas Allocation for Chained Cross-Contract Calls HOT 2
- publishing: add a CI task to test packaging/building of all published crates individually HOT 1
- High cardinality metric HOT 4
- Downloading blocks stuck at 0.00% HOT 3
- Removing the validator key and then sending SIGHUP to the neard process does not appear to stop it validating
- [network] Expand STUN-based IP self-discovery to all nodes
- [network] Implement Tier3 connection pool
- [network] Implement p2p state part transfer
- [state sync] Update sync actor to use p2p state part transfer
- [network] Implement rate limiting for state part requests
- [Tracking Issue] P2P State Part Transfer
- Validate FT transfer benchmark performance HOT 3
- Print an error log when the CPU doesn't have the required features
- Spammy network messages in the logs HOT 1
- Locust issue in multinode mocknet/ft-bench: no txs send when `num-passive-users` is high
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nearcore.