Giter VIP home page Giter VIP logo

Comments (9)

azban avatar azban commented on August 30, 2024

cc: @nearmax
it would be nice to have the option for all members to be on one line and only wrap starting at method's.

-                message.body
-                       .parents
+                message.body.parents
                        .into_iter()
                        .filter(|h| !self.dag.expect(UNINITIALIZED_DAG_ERR).contains_message(&h))
                        .collect();

relevant discussion and links:
rust-lang/rustfmt#3210
rust-lang/style-team#66
rust-lang/style-team@bec533c

this is not possible with rustfmt and it seems like they are opposed to adding the option

from nearcore.

MaksymZavershynskyi avatar MaksymZavershynskyi commented on August 30, 2024

The linter gets quite terrible:
https://gitlab.com/nearprotocol/nearcore/-/jobs/123228836
If we want linter and it does not allow us to turn this wrapping off then we should disable the linter and fork it. This should not be blocking us

-        let (v0,v1,v2,v3,v4,v5,v6,v7,v8,v9,v10,v11,v12,v13,v14,v15,v16,v17,v18,v19,v20,v21,v22,v23);
+        let (
+            v0,
+            v1,
+            v2,
+            v3,
+            v4,
+            v5,
+            v6,
+            v7,
+            v8,
+            v9,
+            v10,
+            v11,
+            v12,
+            v13,
+            v14,
+            v15,
+            v16,
+            v17,
+            v18,
+            v19,
+            v20,
+            v21,
+            v22,
+            v23,
+        );

from nearcore.

ilblackdragon avatar ilblackdragon commented on August 30, 2024

@azban we are ok with clippy / cargo fmt for now?

from nearcore.

evgenykuzyakov avatar evgenykuzyakov commented on August 30, 2024

Seems clipply disabled on nightly. I'd prefer to get it back

from nearcore.

MaksymZavershynskyi avatar MaksymZavershynskyi commented on August 30, 2024

Last time I checked clippy did not compile on CI because of the nightly switch.

from nearcore.

azban avatar azban commented on August 30, 2024

@bowenwang1996 fixed that in #675

i'm fine with clippy.. we still haven't converged on cargo fmt for linting, and i feel like it would be a good idea to have a strict formatting tool to use at some point

from nearcore.

bowenwang1996 avatar bowenwang1996 commented on August 30, 2024

I disabled clippy again due to its instability with nightly. On some days it work with nightly and when we are not lucky, it doesn't.

from nearcore.

MaksymZavershynskyi avatar MaksymZavershynskyi commented on August 30, 2024

@azban I am fine with rustfmt. Sometimes it derps, but it seems to be the widely accepted standard and we should be using at least something, so let's use it.

from nearcore.

ilblackdragon avatar ilblackdragon commented on August 30, 2024

Closing this, as we have now CI check.

from nearcore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.