Giter VIP home page Giter VIP logo

Comments (14)

NekR avatar NekR commented on August 12, 2024

Hi @ferhtgoldaraz, thanks for you feedback!

Loader should in this situation and it's very weird that it doesn't. Hope we'll be able to figure it out, but I will need your help here.

First of all, can you please put a debugger; statement in fail function and check from where error is reported in call-stack? You most likely will need to enable "Async" in call-stack settings in Chrome to get all the function there since async-loader uses setTimeout() in some places.
image

Also some other modules like Vue may cause problems because they do really weird tricks to package everything, but check with debugger is a good start.

Thanks for reporting!

from async-module-loader.

ferhtgoldaraz avatar ferhtgoldaraz commented on August 12, 2024

OK, Here it goes. From top to bottom:

image

image

image

image

image

from async-module-loader.

ferhtgoldaraz avatar ferhtgoldaraz commented on August 12, 2024

I can also give you one where the default require ensure works as expected if you wold find it useful. I can't really say I am able to read what's going on.

Note also that there is a lot more than just vue being able to cause weirdness. This is a Meteor project, without some packages that you would usually have (ecmascript, blaze), usuing a package that enables the use of webpack inside it (with some hard-coded preconfigured stuff (code here)...

And then vue on top of that.

I really hope none of that matters, :).

from async-module-loader.

NekR avatar NekR commented on August 12, 2024

Thanks for showing screenshots! As I see, you are also using hot reloading. which didn't tested actually :(
Also I see that require.ensure isn't overridden by async-module-loader, so I guess some other loader/plugin does this too. Hope it's hot-reloading, then I will be able to fix easily. Will check it.

from async-module-loader.

ferhtgoldaraz avatar ferhtgoldaraz commented on August 12, 2024

Awesome. I can test it without hot reloading by simulating a production environment, but that minifies the code, so the stack traces will not be very helpful. Will do that later.

from async-module-loader.

goerwin avatar goerwin commented on August 12, 2024

Im having this issue too 😢

from async-module-loader.

NekR avatar NekR commented on August 12, 2024

Hi @erwingaitano, do you have this issue with hot reloading?

from async-module-loader.

goerwin avatar goerwin commented on August 12, 2024

It's not just hot reloading, it also happens after a full refresh. The chunk is loaded correctly with a 200 in the network tab but the error callback is called instead of the success one.

PD: I started playing with webpack 2-beta and its System.import method instead of this loader and seems to work perfectly. So I guess that webpack 2 now handles this specific issue and there's no need for any bundle-loader.

from async-module-loader.

NekR avatar NekR commented on August 12, 2024

It's not just hot reloading, it also happens after a full refresh.

By hot reloading I meant that if it's enabled at all -- this plugin is not working.

webpack 2 indeed solves bundles-loading problem, so if you are using it, then you have no need in this plugin/loader.

from async-module-loader.

denich avatar denich commented on August 12, 2024

Hi @NekR ,
Have the same issue and it's really appears in case hot reloading enabling (same issue as on @ferhtgoldaraz 's screepnshots).
Can you help here?

from async-module-loader.

NekR avatar NekR commented on August 12, 2024

@denich I personally don't use hot reloading, so right now I have no idea what happens where. If I'll have time, maybe I'll look into it.

from async-module-loader.

denich avatar denich commented on August 12, 2024

@NekR It would be nice if you do!

from async-module-loader.

NekR avatar NekR commented on August 12, 2024

@denich @ferhtgoldaraz if it's still makes sense for you, with a new version it should now work fine with HMR. At least it won't fail anymore, but some times you may not get errors reporting because of race condition.

from async-module-loader.

ferhtgoldaraz avatar ferhtgoldaraz commented on August 12, 2024

The next time I try to confront this I'll try to rmemeber to comment here how it goes, thanks!

from async-module-loader.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.