Giter VIP home page Giter VIP logo

Comments (12)

Neo-Mind avatar Neo-Mind commented on June 12, 2024

I'll have a look at this.

from warp.

cassioronchetti avatar cassioronchetti commented on June 12, 2024

Nice to hear that!! I want this one so badly! I will help you to find other issues until them.

from warp.

cassioronchetti avatar cassioronchetti commented on June 12, 2024

Any updade on this?

from warp.

Neo-Mind avatar Neo-Mind commented on June 12, 2024

@cassioronchetti can you try out the patch. I have made some changes.
You might need to do a @refresh once you're on the map.

from warp.

cassioronchetti avatar cassioronchetti commented on June 12, 2024

Didn't work, I tried on 2010-07-30aRagexe which is the most used client for pre-renewal classic server in my country.

from warp.

Neo-Mind avatar Neo-Mind commented on June 12, 2024

@cassioronchetti Try it now. You would need to refresh once you are on the map.
To fix this part, you would need to send the map flag before the idle packet is sent.

(20121010 onwards a different packet is used, hence this problem doesn't arise).

Btw I heard from Ai4rei that the dates between (but not including) 2010-07-28RE & 2010-08-04RE are defective.

from warp.

cassioronchetti avatar cassioronchetti commented on June 12, 2024

It's working like a charm!! Congratulations Neo!! I wish I had this knowledge to do these kinds of things!!

Well done! Btw is it possible to follow you on instagram or facebook? I am a big fan of your work!

from warp.

Neo-Mind avatar Neo-Mind commented on June 12, 2024

OK, gr8. Well, I am there at discord and I recently joined twitch (haven't really used it much though).
https://www.twitch.tv/NeoMnd

Anyways I am closing this issue now :)

from warp.

Neo-Mind avatar Neo-Mind commented on June 12, 2024

@cassioronchetti Are you still facing issues with the patch?

from warp.

cassioronchetti avatar cassioronchetti commented on June 12, 2024

Hello Neo! I have the issue about @refresh to display the emblem, because I don't know how to send the map flag before the idle packet is sent.

Another issue you can see in the screenshot below. When you leave the screen from your enemies the emblem doesn't disappear, it stays in the screen while you are walking on the map. (using 2010-07-30aRagexeRE)

Another thing I noticed is that by fixing this patch for old clients, it suddently broke the same patch for new clients. I was testing it on 2018-04-18 and it wasn't working. I think one solution would be making two patches, one that works on old clients and one for new clients.

screenHercules032

screenHercules033

from warp.

Neo-Mind avatar Neo-Mind commented on June 12, 2024

Thanks for waiting. All the fixes have been pushed. Please check and let me know.

As I stated before, all clients >= 20121010 have a separate packet that indicates the BG mapflag (along with others).
The client sets up the icon in response to this packet.

In older clients, the mapflag is checked after an idle packet is sent.
So in your server, while changing maps, you need to set the mapflag first and then send the idle packet.

It would be best to discuss that part in the server forum.

from warp.

cassioronchetti avatar cassioronchetti commented on June 12, 2024

It's working fine in new clients!

from warp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.