neon can't compile netstandard2.0 assemblies about neo-devpack-dotnet HOT 11 CLOSED

The point here is to make the smart contract build process as natural and familiar to the C# developer as humanly possible.

from neo-devpack-dotnet.

Quick check in the debugger, ModuleConverter.TryInsertMethod is receiving a null Cecil MethodDefinition instance. ModuleConverter._ConvertCall is failing to resolve the method reference to Neo.SmartContract.Framework.Services.Neo.Storage::Put, but the resolve call is inside a try/catch block that swallows the exception, leading to the null ref exception down the line in TryInsertMethod

from neo-devpack-dotnet.

I make some test.I think it is not a bug.

When we build "dotnet framework" project, the depend dll like Neo.SmartContract.Framework.dll will be copy to same path.
but build "dotnet standard" project,will not copy that file

when we build a "dotnet framework" project we will got

HelloWorld.dll
HelloWorld.pdb
Neo.SmartContract.Framework.dll

3 files

when we build a "dotnet standard" project we will got

HelloWorld.dll
HelloWorld.pdb

2 files

we will got a error when neon build avm because miss file:Neo.SmartContract.Framework.dll

I add a standard project with a neo.smartcontract.framework.dll
https://github.com/neo-project/examples/tree/Branch_helloword_standard/csharp/helloworld_stand

and neon build succ

another way is use “dotnet publish” for netstandard project

from neo-devpack-dotnet.

I will try to make a better error info in this situation.

from neo-devpack-dotnet.

Nice to know it's a simple issue. However, instead of forcing the developer to copy the dependency, can we check the nuget global package folder first? https://docs.microsoft.com/en-us/nuget/Consume-Packages/managing-the-global-packages-and-cache-folders

Also, the .deps.json file will contain the path within the global package folder. For example, on my windows machine the global package folder is C:\Users\harry.nuget\packages. The .deps.json file has the following JSON data in the targets object:

"Neo.SmartContract.Framework/2.9.3": {
  "dependencies": {
    "NETStandard.Library": "2.0.3"
  },
  "runtime": {
    "lib/netstandard1.6/Neo.SmartContract.Framework.dll": {
      "assemblyVersion": "2.9.3.0",
      "fileVersion": "2.9.3.0"
    }
  }
},

Sure enough, the path to the DLL on my machine is "C:\Users\harry.nuget\packages\neo.smartcontract.framework\2.9.3\lib\netstandard1.6\Neo.SmartContract.Framework.dll"

from neo-devpack-dotnet.

@devhawk
use “dotnet publish” for netstandard

from neo-devpack-dotnet.

I think that this is working. Can you check @devhawk ? At least I tested with #131 and it worked fine using .net standard. Thanks.

from neo-devpack-dotnet.

Yes, I was able to compile the hello world contract to NEF from build artifacts alone using master branch of this repo. Can we port this back to master-2.x branch?

from neo-devpack-dotnet.

Which was exactly the change for allow this?

from neo-devpack-dotnet.

@shargon can we port #131 to 2.x?

from neo-devpack-dotnet.

Yes, I will

from neo-devpack-dotnet.