Comments (3)
The same thing you do in the tests. According to the specification https://jsonapi.org/format/#fetching-sparse-fieldsets there is no need to do that.
Here a snippet from the class FieldSetFilter:77-81
$parentType = $position->getParentType();
if ($this->hasFilter($parentType) === true) {
return isset($this->getAllowedFields($parentType)[$position->getParentRelationship()]);
}
It checks whether the name of the relationship type is named in the required fields. To be sepc conform this method should always return true imho.
from json-api.
I know there were a discussion on this topic in #105 and #134. In my opinion the example in the 1.0 spec requires my interpretion:
GET /articles?include=author&fields[articles]=title,body&fields[people]=name HTTP/1.1
Accept: application/vnd.api+json
There is no reference of the author or people in the requested fields. But I assume the author should be included. Otherwise this would be nonsense
from json-api.
Wrong button on comment pressed 🙈
from json-api.
Related Issues (20)
- Include related resource into output in its entirety? HOT 11
- Include array of `Identifier`s HOT 5
- What's happened to include relationships in schema `getRelationships` method HOT 40
- Relationship data is parsed even if parser is not parsing the data HOT 13
- EncoderPropertiesTrait::withIncludePaths only works with arrays HOT 1
- subUrl property is private - BaseSchema HOT 6
- [Question] How to exclude relationships on collections by default? HOT 9
- Catch exceptions from json_encode HOT 7
- Error while using BaseQueryParser and Encoder together HOT 8
- Fetch a link from an existing Element HOT 2
- How to encode custom array NOT LARAVEL MODEL INSTANCE HOT 4
- How to create nested relationships HOT 3
- Member names are converted to kebab-case HOT 1
- stricter typing with psalm
- Relationship data generator is invoked more than once if data is empty HOT 16
- Support interface/superclass based mapping in SchemaContainer HOT 1
- How can I fix incorrect links in my `included` compound document section? HOT 1
- Problem with PHP version 8.1
- accept same type on Encoder::instance
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-api.