Recommended code change about lipopi HOT 8 OPEN

I guess it would depend on if the low battery output on the PowerBoost goes low or if it goes open circuit when the battery is low. Have you tested it to see if it still shuts down on low battery?

from lipopi.

I'll try and let you know.

from lipopi.

I've tested it, seems to work fine, at least for me. I haven't had a chance to check the datasheet of the chip used on the Adafruit inverter, but I would assume it would give a good solid logic high and low.

from lipopi.

Excellent, would you like to submit a pull request?

from lipopi.

I've never done a pull request, nor am I sure what it is. Any advice?

from lipopi.

Its how you contribute to open source code on Github :)
Basically you request a change (pull request) and the maintainers accept it and it gets merged into the project.

I can understand if you'd rather not but its quite rewarding if you did want to get involved, once you have helped one project it can get addictive and you end up contributing quite a bit even if its just correcting spelling mistakes in various projects :)

from lipopi.

I'm very happy to contribute if I can, but didn't know how, and not everyone is interested. I'll see what I can figure out :)
Also, I learned enough Python to add a function where the Pi won't shut down unless if you've held down the power button longer than a pre-defined amount of time. I cloned your Github and made the change there. Should I do a pull request for that as well? I assumed not everyone would be interested in that, although in my case, I'm using a button in an existing item, and wanted to share functionality.

from lipopi.

I think people would be interested in it but it would be best if they can enable the functionality optionally? Perhaps by setting a variable to turn it on?

from lipopi.