Conceal eats adjacent whitespace about tree-sitter-vimdoc HOT 18 CLOSED

@justinmk For #trim! to address this, would it need to not just trim empty lines, but also whitespace from the beginning & end of (all lines in the) region?

from tree-sitter-vimdoc.

No thanks, I have a PR otw

from tree-sitter-vimdoc.

hopefully will be addressed when #trim! is upstreamed. offset! also is worth noting.

nvim-treesitter/nvim-treesitter#2850

from tree-sitter-vimdoc.

As is, #trim! would not help here as you noticed. We'd need a new variant that works horizontally (only), or add a keyword that controls the mode.

from tree-sitter-vimdoc.

proposed workaround: #28

from tree-sitter-vimdoc.

metadata[capture_id].range isn't working like I'd expect on v0.8.0, at least given the #offset! examples I've seen. Here's some debug output from nvim-treesitter-playground using this in highlights.scm (all other (#set! conceal "") directives commented out):

(tag
  text: (_) @label)
(tag
  "*" @conceal (#set! conceal "")
  (#match? @conceal "^\\*$")
  text: (_))
(tag
  "*" @conceal.left (#set! conceal "")
  (#offset! @conceal.left 0 0 0 -2)
  (#match? @conceal.left "^\\s+\\*$")
  text: (_))

You can see that the modified range for the "*" anonymous node should cause all but * (column range 49–51) to be concealed, but the whole node range is still concealed.

I attempted to do this without match, but there seems to be some interesting behavior with sibling ordering & anonymous nodes:

(tag
  text: (_) @label)
(tag
  text: (_)
  "*" @conceal.right (#set! conceal "")
) ; @mytest
; (tag
;   "*" @conceal (#set! conceal "")
;   (#match? @conceal "^\\*$")
;   text: (_)
; )
(tag
  "*" @conceal.left (#set! conceal "")
  ; (#offset! @conceal.left 0 0 0 -2)
  ; (#match? @conceal.left "^\\s+\\*$")
  text: (_)
)

@conceal.right is properly applied only after a sibling text: (_), but @conceal.left applies to both.

Also, for some bonus fun, if I uncomment that ; @mytest capture on the pattern containing @conceal.right:

@mytest is now a capture that has metadata.conceal set! This feels pretty wrong and I'm worried it's a tree-sitter problem.

from tree-sitter-vimdoc.

@vigoux

from tree-sitter-vimdoc.

Also have this bug.

from tree-sitter-vimdoc.

Some cases are still not fixed. For example, Whitespace is still getting trimmed when you only have tags on a line like

							*:setl* *:setlocal*

Becomes

:setl :setlocal

from tree-sitter-vimdoc.

Yes, seems like whitespace is included in the first node of a line. Not sure why.

from tree-sitter-vimdoc.

Also happens with links; see, e.g., api.txt, line 1547f (and many other places).

from tree-sitter-vimdoc.

Links that are the first node in the line..?

from tree-sitter-vimdoc.

Yes.

from tree-sitter-vimdoc.

This actually happens for all nodes as far as I can see: check line 22 of api.txt with hi link @text.uri Underlined -- the underline extends to the beginning of the line.

from tree-sitter-vimdoc.

Even with current HEAD? Is the issue fixed with 31fcaca ?

from tree-sitter-vimdoc.

Is that in core?

from tree-sitter-vimdoc.

not yet

from tree-sitter-vimdoc.

Ah, OK. Want me to bump the parser and queries, or is there something you'd like to hold out for?

from tree-sitter-vimdoc.