Merge injection token for cache and cache instance about cache-manager HOT 7 CLOSED

I think the the "issue" with having that indirection (NestCache type) is that isn't that clear that the cache manager is from cache-manager lib. But I'm fine with abstracting it away

Also, I'd suggest this one instead:

import { Cache } from '@nestjs/cache-manager';

@Controller()
export class Foo {
  constructor(private cacheManager: Cache) {} // no need to recall the token

from cache-manager.

I think the the "issue" with having that indirection (NestCache type) is that isn't that clear that the cache manager is from cache-manager lib. But I'm fine with abstracting it away

Also, I'd suggest this one instead:

import { Cache } from '@nestjs/cache-manager';

@Controller()
export class Foo {
  constructor(private cacheManager: Cache) {} // no need to recall the token

yeah, it works

yes, I think either way is ok, it's just better to import 1 thing from 1 lib than 2 things from 2 libs

from cache-manager.

Personally, I would rather import the specific token from the Nest wrapper and the actual type from the implementation library. Yes, it's another library to have to worry about, in terms of making sure it comes from the right place, but it also means that Nest can use peerDependencies for the library and allow devs to install whichever version of the library it needs, meaning less maintenance on our side when updates are released.

from cache-manager.

We could fix this up by adding the extra useExisting provider (= thus not introducing any breaking changes)

from cache-manager.

Personally, I would rather import the specific token from the Nest wrapper and the actual type from the implementation library. Yes, it's another library to have to worry about, in terms of making sure it comes from the right place, but it also means that Nest can use peerDependencies for the library and allow devs to install whichever version of the library it needs, meaning less maintenance on our side when updates are released.

From my understanding, this library is tightly related to cache-manager and it's appropriate to link cache manager as a peer dependency. It will cause trouble when user installed very old or very new versions, if he didn't know what the version that @nest/cache-manager is actually using.

from cache-manager.

We already use peerDeps, so as long as cache-manager<=5 is installed, this library will work. If we set to dependencies then npm/yarn/pnpm will auto-install the package

from cache-manager.

Let's track this here #256

from cache-manager.