Comments (5)
BrunnerLivio
commented on June 4, 2024
1
@andreialecu Alright makes sense to me! Let's go forward with your PR then :)
from terminus.
BrunnerLivio
commented on June 4, 2024
1
Released with 9.1.4 🎉
from terminus.
andreialecu
commented on June 4, 2024
Fixed in #2084 (/cc @BrunnerLivio)
from terminus.
BrunnerLivio
commented on June 4, 2024
@andreialecu Curious; why would you want to run a synchronous health check?
from terminus.
andreialecu
commented on June 4, 2024
Because I have a specific case where I have a stream that sometimes randomly stops working, so I store a lastMessageReceived timestamp and check if nothing got in in the past 2 minutes, then fail the health check because of it.
I had to dig through the Terminus code to see why this wasn't working right.
If non async healthchecks should not be supported, the types could prevent a non-promise from being passed. But they specifically allow it:
terminus/lib/health-indicator/health-indicator.ts
Lines 8 to 10 in 8fdf979
So this seemed like a bug to me.
PS: I'm currently working around it by passing an async function, but I thought someone else might run into this in the future, and it was worth fixing.
from terminus.
Related Issues (20)
- Ability to run health checks in parallel HOT 3
- After PR #1970 (update from 9.0.0 to 9.1.0) there is an error with TERMINUS_ERROR_LOGGER HOT 2
- NestJS Terminus has an undeclared dependency on Axios HOT 1
- Typescript issues with axios >= 0.27 HOT 1
- Allow custom logger implementation for health check service HOT 10
- Named swagger schema HOT 4
- Optional peerDependencies are not declared in manifest
- Nest could not find MikroORM element (this provider does not exist in the current context) HOT 1
- MicroserviceHealthIndicator pingCheck() failed when error is undefined HOT 2
- MikroOrmHealthIndicator does not work with the `defineConfig` helper HOT 4
- this library does not support Nestjs 10.0.0 HOT 5
- On shutdown, health request before signal interrupted with ECONNREFUSED
- Cached responses 200 -> 304 HOT 6
- HttpHealthIndicator.responseCheck not handles network errors HOT 1
- Adding a gracefulShutdownTimeout option for 0-downtime deployment on Kubernetes HOT 6
- nest10 health check return Service Unavailable Exception HOT 1
- Mikro ORM check returns healthy although not connected HOT 7
- Schema does not match health-indicator-result interface HOT 7
- DiskHealthIndicator always reports: "Used disk storage exceeded the set threshold" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminus.