InjectRepository fails to detect circular imports about typeorm HOT 4 CLOSED

There are some problems with circular dependencies and decorators, but as far as I know, in this case @InjectRepository(class) will be fine even if class has circular deps inside. I actually tested this against hundred of repositories already.

from typeorm.

Thanks for the answer. In fact, I did some tests wrong and it seems that this wasn't faulty in my code. Mostly the issue I had is that my NestJS service used some TypeORM repository and the same TypeORM entity was doing a call back (through some other files/logic) to the same service.

In sum, I had a circular dependency, which typescript didn't report and the only message I got was that the class was undefined inside the @Injectrepository(class). And this class wasn't even the one having the issue of the circular dependency.

I guess this is something in a higher level, in TypeScript, that is not detected there... But also could be good to warn the user that if this class passed in @Injectrepository(class) is undefined, there is a high possibility that there is a circular dependency somehow!

from typeorm.

I added an additional check in 6.1.0 :)

from typeorm.

@kamilmysliwiec is it possible to know what's involved in the circular dependency? I had the problem that InjectRepository was trying to inject a null entity, now it seems that the code checks if it's null but I don't see how my code is circularly dependent as I've just added an entity custom validation constraint the injects the above class repository in its constructor

from typeorm.