[FR] refactor to only import needed decorators-> lodash modules about helpful-decorators HOT 11 CLOSED

It's not. I only import the throttle module:

const throttleFn = require('lodash.throttle');

from helpful-decorators.

@NetanelBasal yes you do but in index.ts your import all decorators.
Each one importing its lodash counterpart.

So you always end up with up even if you only use one

from helpful-decorators.

No, Webpack should tree shake the rest.

from helpful-decorators.

What do you mean? and it doesn't. I have tested it using webpack report feature

from helpful-decorators.

You should build in production mode, and Webpack should tree shake what's not in use.

from helpful-decorators.

@NetanelBasal thanks for letting me know about tree shaking. I didn't know about it.
Spent a few days making my app work with tree shaking. Now it does. however even if webpack sees that only throttle is used in my project:

[185] ../node_modules/helpful-decorators/dist-web/index.js 4.13 KiB {2} [built]
      [only some exports used: throttle]

the other lodash imports are not removed. Could it be because those are not ECMAScript modules?

[248] ../node_modules/lodash.debounce/index.js 10.5 KiB {2} [built]
      ModuleConcatenation bailout: Module is not an ECMAScript module
[249] ../node_modules/lodash.throttle/index.js 13 KiB {2} [built]
      ModuleConcatenation bailout: Module is not an ECMAScript module
[250] ../node_modules/lodash.once/index.js 6.93 KiB {2} [built]
      ModuleConcatenation bailout: Module is not an ECMAScript module
[251] ../node_modules/lodash.memoize/index.js 16.6 KiB {2} [built]
      ModuleConcatenation bailout: Module is not an ECMAScript modul

from helpful-decorators.

Weird, because the file itself is. Maybe we should add the sideEffects: false option.

from helpful-decorators.

@NetanelBasal what do you mean add it as an option? "sideEffects": false is already in the package.json file of your module

from helpful-decorators.

Here. https://github.com/NetanelBasal/helpful-decorators/blob/master/package.json

from helpful-decorators.

@NetanelBasal it is already there in the published package

from helpful-decorators.

Oh missed that.

from helpful-decorators.