Giter VIP home page Giter VIP logo

Comments (3)

jsdario avatar jsdario commented on May 23, 2024

Hi @msevestre, thanks for opening the issue.

The goal of this component is to change colors in a HSL / HSV model. The color selection is not based on the image, but on the angle and position of the thumb. Changing the background image would not suffice, you would need to change how the color is retrieved.

This is easy, and I would welcome a PR that is backgrounds compatible, but its implementation it's not planned.

Related πŸ‘‰ #13

from react-native-color-wheel.

msevestre avatar msevestre commented on May 23, 2024

I don't think this is related to #13 whatsoever. I am not asking for black color. Just asking for darker color for green.

The goal of this component is to change colors in a HSL / HSV model. [...] Changing the background image would not suffice, you would need to change how the color is retrieved.

Yes this is clear that some code will need to be implemented to make it work. But don't you think that this would make sense to have a green color range that is bigger (for a lack of a better word) that what is available now? The green is almost the same throughout the wheel area
image
whereas blue and red go from light to dark.

This is easy, and I would welcome a PR that is backgrounds compatible,

I am not sure what you mean with background compatible. If you give me some pointers however on how this could be implemented, I could give it a try

from react-native-color-wheel.

jsdario avatar jsdario commented on May 23, 2024

Sorry I meant backwards compatible (editing soon).

I am afraid you already have available 360ΒΊ of hue. The only way to get more green options, would be to have a higher definition, but I wonder how the user experience would be.

You can turn a color darker, reducing it's luminosity or brightness, properties of the HSV format. Normally other color pickers offer a second spinner or UI element to increase the range of the colors, but this wheel is supposed to be the wheel only.

I can't come up with an elegant and easy solution, knowing those restrictions. If you can come up with one, I'm open to it.

More info about color and encodings:
https://en.wikipedia.org/wiki/HSL_and_HSV

from react-native-color-wheel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.