Potential Problem with `device_type` initializer about netbox-docker HOT 3 CLOSED

Can you please post an example of a yaml that triggers this behavior?

from netbox-docker.

Sure, here it is:

https://gist.github.com/bdlamprecht/04ba20b53edc192fdccbbe09550609c7

Although, I've noticed that potentially this only happens when a device_type that I've manually created (through the WebUI or through the API) is then added to the device_types.yml and then the container is brought up again.

This may be an unsupported workflow (manually adding a type then recreating a container), but in reality, should it be?

from netbox-docker.

I was able to load your device_types.yml two times with no problems.

If you already have data in Netbox that matches one of the initializers, that's a complex problem. Because there are no primary keys (i.e. ids) in the initializers, it's not possible to distinguish the entries precisely. That's why all given attributes must match exactly for an object not to be created again.

If there is just a very tiny difference, then Django will try to create a new object. But in your case there is already an object, that is similar, yet not identical, and therefore Django will try to create a new object. But it fails to do so, as some unique constraint is violated, i.e. because the value for 'model' in combination with the given manufacturer already exists.

I've tried to come up with a solution that circumvents this problem. But there is not one-size-fits-all solution and that solution is therefore bound to fail for other use-cases. That's why I will leave the scripts as they are.

If you want to create an initializer that supports your case, you may want to adjust (clones of) the existing initializers.

The Django method, that you need to handle for your case, is objects.create_or_update(). The solution would be to pass just the parameters, that you want to use for identification, as the main arguments, and all the other parameters as default=:

device_type, created = DeviceType.objects.get_or_create(params.pop('model'), params.pop('slug'), default=params)

from netbox-docker.