pc_notify_with_timeout inside pc_client_poll will never returns. about libpomelo2 HOT 6 CLOSED

pc_client_cleanup will wait the uv loop to terminate, if you call pc_client_cleanup in callbacks, it will deadlock.

from libpomelo2.

it is pc_notify_with_timeout this time, not pc_client_cleanup.

from libpomelo2.

there are two mutexes here, polling_event_queue_mutex and tcp_send_queue_mutex
there are two threads, polling thread, uv loop thread

polling thread:
acquire event queue mutex -> invoke callback -> call pc_notify_with_timeout -> want send queue mutex

uv loop thread:
accquire send queue mutex -> uv tcp send ok -> add send complete event -> want event queue mutex

then, deadlock!

solution:
uv loop thread: after fetch a send item, release the send queue mutex

from libpomelo2.

solution 2:
when polling the event queue, release the event_mutex before pc__handle_event and re-acquire it after pc__handle_event finished.

from libpomelo2.

here is a pr for solution 2: #67.

from libpomelo2.

ok, goto #67 ,closing here

from libpomelo2.