composite columns with getColumnByName not working? about astyanax HOT 7 CLOSED

Your pojo will need to implement the Comprable interface. Columns are stored internally in maps.

from astyanax.

It seems to me that from an API perspective the comparable logic beste be done in the getColumnByName using reflection, otherwise every one using the API needs to implement a comparable.

from astyanax.

More specifically you'll need to implement hashCode, compareTo and equals. I'll modify the docs to reflect this requirement.

from astyanax.

I really think it is a better idea to try and not have the user have to do this. It will make the implementation much uglier. Can't we use the utility methods provided by Apache commons to add these methods via reflection? The Pojo would then need to extend something, but adding three methods to create a two column composite is not nice.

from astyanax.

Point taken. I'll take a look.

from astyanax.

You may want to add a generic bound to enforce Comparable implementation check at compile time (with or without reflection impl. this will add safety). Also to check if hashCode() and equals() are implemented by T AnnotatedCompositeSerializer may create two instances of T in it's constructor and compare them and their hashcodes. If they are equal - methods are implemented.

public class AnnotatedCompositeSerializer<T extends Comparable<? super T>> extends AbstractSerializer<T> {

from astyanax.

Also in documentation for that serializer you may add a link to Guava's wiki page with examples of how to simply implement compareTo/hashCode/equals methods.

from astyanax.