JmxMetricPoller: Trouble adding Tabular metrics about servo HOT 2 CLOSED

I'm not sure why it creates a map and loops there as it will only have iteration.

This code was originally for some polling use-cases based on the table types that we had use-cases for at the time. They were all essentially lists with two columns: key and value. So it needed to extract the value of the key column and map it to the value of the value column. For example, system properties are mapped into JMX in that way:

It sounds like you are trying to read something that has a different table structure. That is it has potentially many columns and the key is actually the column name. I don't think that would work as it is written today. Not sure how easy it would be to support as somehow the structure of the table would need to be understood for a given mbean. So there would need to be some configuration.

At Netflix we do not currently use the Servo JmxMetricPoller and in general Servo is in maintenance mode. We do have some use-cases for extracting data via JMX that are handled by the spectator-ext-jvm library. It supports configurations for what data to fetch and how to map it in. Not sure if it would support the table formats at this time as the mapping has been mostly focused on use-cases we have. So we add to it as we have the need. That said, PRs are welcome if you have a suggestion for improving it.

from servo.

Ah, understood! My case looks something like this:

Each row in the table is considered a key-value pair (i.e. "time" is the key and get("time") would be it's value, 332). The table itself is an instance of the CompositeData class. There can be multiple CompositeData instances (i.e multiple tables) associated with one attribute. If I can suggest an improvement I will submit a PR.

from servo.