Giter VIP home page Giter VIP logo

Comments (9)

shoothzj avatar shoothzj commented on August 16, 2024

Thanks for your reply, let me take a look this weekend

from json-smart-v2.

ewoelfel avatar ewoelfel commented on August 16, 2024

I guess the limitation was done due to this CVE the error was found under Jfrog.

So it seems to be necessary, however a patch version upgrade would not be sufficient for this breaking change imho.

This is also related to the issue #132

from json-smart-v2.

shoothzj avatar shoothzj commented on August 16, 2024

I think #133 can close this issue. Feel free to reopen it.

from json-smart-v2.

ColdFireIce avatar ColdFireIce commented on August 16, 2024

As I agree, that 400 should be enough depth, the argument still stands.
Shouldn't there be an option to override this default value?

from json-smart-v2.

shoothzj avatar shoothzj commented on August 16, 2024

@ColdFireIce I think it was hard coded to fix security problems. It's reasonable for users to override this default value

from json-smart-v2.

shoothzj avatar shoothzj commented on August 16, 2024

@ColdFireIce Since depth 400 is enough for mostly scenario. And now we only have one int param(premissive). I believe it can be scheduled in future version.

from json-smart-v2.

UrielCh avatar UrielCh commented on August 16, 2024

V2.4.10 is released.

wait for confirmation before closing the issue.

from json-smart-v2.

ColdFireIce avatar ColdFireIce commented on August 16, 2024

Thank you for the release. But this issue does not relate to the Problem in #132.
This issue here asks for a feature in the future to override the default value for the call-depth.

from json-smart-v2.

UrielCh avatar UrielCh commented on August 16, 2024

Okay, please provide me a case where anyone needs more than 400 call-depth.

If you find one we can add an argument to customize this limit.

from json-smart-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.