Comments (3)
Ignore previous comments, I can disable this per-platform.
from geoapi.
I always considered assembly signing a PITA, maybe we can simply get rid of it also in windows targets?
Anyway, removing signing in windows targets should be considered a breaking change, because signed dll's cannot use NTS dlls anymore.
I think assembly signing was introduced first when I developed NTS as SQL-CLR long time ago...
from geoapi.
Hello,
Maybe I am missing something, but it seems that removing assembly signing from the .NET Standard version only is preventing to provide .NET Standard libraries referencing GeoAPI to .NET Framework projects referencing GeoAPI too.
I attached an example project to illustrate the issue:
GeoApiSigningTest.zip
I have a TestNetStandardNuGetLib project targeting .NET Standard 1.0, and referencing GeoAPI 1.7.5-pre006. Since I'm targeting .NET Standard 1.0, it references the .NET Standard 1.0 unsigned version of GeoAPI.
I have another project, TestNetFrameworkApp, targeting .NET Framework 4.5.2, also referencing GeoAPI 1.7.5-pre006. However since I'm targeting the .NET Framework, it actually references the .NET 4.5 signed version of GeoAPI.
When I try to reference TestNetStandardNuGetLib in TestNetFrameworkApp and use some GeoAPI related code, I can't compile my project because these two projects are referencing what appears to the compiler to the be two different assemblies since they have a different signature.
A workaround for me is to do multi targeting in my TestNetStandardNuGetLib, so the .NET 45 version of my lib would reference the .NET 45 version of GeoAPI. But then, .NET Standard projects referencing my lib will have to do the same thing, etc.
I am curious, why are you saying that assembly signing is not supported in .NET Core? I have .NET Core projects referencing signed .NET Standard assemblies like Newtonsoft.Json apparently without issues.
Best regards.
from geoapi.
Related Issues (20)
- Get permissions from all contributors (at least all who have made significant changes) to agree to license change. HOT 6
- Relicense GeoAPI.Core under BSD3 HOT 1
- Should ILineString include Count? HOT 5
- GeoAPI 1.7.4 to 1.7.5 broke come code HOT 13
- Is the GeoAPI 1.7.5 Nuget package missing dll's? HOT 1
- It looks like GeoAPI.Geometries.IGeometry.Intersection doesn't carry over data in the UserData property. HOT 4
- Remove GeometryServiceProvider.Instance HOT 4
- Remove obsolete interfaces, classes and members HOT 1
- Future of Coordinate class HOT 1
- [question] Typescript definition for geoapi HOT 1
- CoordinateXY.CompareTo(object) is incorrect HOT 3
- Remove ICloneable implementations across the board
- Target just .NET Standard 2.0
- Remove reflection-based GeometryServiceProvider.Instance bootstrap HOT 1
- Remove redundant interface members HOT 2
- Replace notable interfaces with abstract classes, for multiple reasons HOT 8
- Reconsider use of SerializableAttribute HOT 2
- Remove (standalone) GeoAPI HOT 13
- support .NET core 3.0 HOT 2
- Serialization BUG
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geoapi.