RFE: Support for HTTP byte Range requests about netty HOT 11 OPEN

Yes. It would be great if Netty has such handler. It could be part of the org.jboss.netty.handler.codec.http package.

Cheers!

from netty.

I did a quick spike to see how this might work.

In particular, that code is very similar to the existing HttpContentCompressor / HttpContentEncoder, so having it live within netty does seem like a good solution.

One problem that I encountered was that I didn't see how to get hold of the response entity size. I had a look at the apache httpd source as well, and having that content length value seems pretty fundamental to a working solution. That means I could quite happily do something for HttpMessage responses, but I'm unsure as to whether it would work with HttpChunks.

I'd appreciate a pointer as to when a HttpChunk is generated versus an HttpMessage, and also how best to integrate a test. The commit in my webbit branch has a functional test, but netty doesn't appear to have tests at a similar level, and it would be helpful to have some guidance as to the preferred form.

from netty.

@jabley did you go any further with this ?

from netty.

I'll check over the next week whether I did any work to port my webbit changes to netty, beyond the spike that I linked to already.

from netty.

I'm curious too :)

from netty.

I didn't get much beyond my original webbit patch and then the above question blocked me. I suggest that I tidy up the patch to track the changes in master and then push a branch with a pull request attached to this issue, so we can tie up the discussion to actual code?

from netty.

Makes sense!

Sent from my iPhone. Excuse any typos....

Am 06.01.2013 um 16:25 schrieb James Abley [email protected]:

I didn't get much beyond my original webbit patch and then the above question blocked me. I suggest that I tidy up the patch to track the changes in master and then push a branch with a pull request attached to this issue, so we can tie up the discussion to actual code?

—
Reply to this email directly or view it on GitHub.

from netty.

I'm doing this now, but the netty code base has evolved somewhat since I first spiked my implementation. I'll hopefully have worked out all the changes in a week or so.

from netty.

Thanks, @jabley. Please feel free to ping us if you find any difficulties porting your code.

from netty.

@jabley any news here ? Or maybe something half done I could port for you ?

from netty.

Sorry, I did have a quick go at trying to re-work it but the netty 4 codebase had moved on quite a bit since I first wrote this and it wasn't something I had time to pursue at the time.

There is the original thing that got written against webbit, which I've commented about separately.

from netty.