Giter VIP home page Giter VIP logo

Comments (4)

eMarco avatar eMarco commented on June 25, 2024

Hi, I must have copy-pasted some old code during one of the last updates. Everything should work now. Thank you for reporting the error.

Regarding the setup / run-time building of the heuristics, I might agree.
The main (and only?) reason we build them at run-time is that most of the original implementations required parameters and input file names as constants / headers.
Once we're done implementing the boost CLI in every script, we can build everything at setup time.
I'll be pretty busy for a while, feel free to create a pull request!

Best,
M

from review.

c0mm4nd avatar c0mm4nd commented on June 25, 2024

Sorry for bothering you while you are busy, but I'm still facing the error. Clearly that in the main branch the dependency network_dismandling.machine_learning on

review/network_dismantling/GDM/predictors.py

Line 27 in 7d09721

from network_dismantling.machine_learning.pytorch.training_data_extractor import (
is still missing and I don't know your function implement

from review.

c0mm4nd avatar c0mm4nd commented on June 25, 2024

And "ReinsertionSupport" is not defined in this type hint:

review/network_dismantling/__init__.py

Line 59 in 5fe9b60

reinsertion: ReinsertionSupport = None

from review.

eMarco avatar eMarco commented on June 25, 2024

Thank you for reporting these errors and for the patience.
Again, I must have merged experimental/old code somewhere in the recent history of this project.
I pushed two hot fixes, but I'll clone the repo in a new folder and test things ASAP.
Let me know if you catch anything else in the meanwhile

from review.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.