Giter VIP home page Giter VIP logo

Comments (4)

justin-tay avatar justin-tay commented on May 28, 2024

So in general passing null as instance data is not valid since the walk actually walks the instance data, it doesn't walk the schema. So null means that there's nothing to walk. The walk listeners can end up with null as the instance node, typically when processing items or properties, this is more so that they can potentially set the node value. If the null instance ends up being passed to the validation functions this is going to throw as they generally don't handle that scenario.

If you are referring to

} else {
walkSchema(executionContext, this.schema, node, rootNode, instanceLocation, shouldValidateSchema,
validationMessages);
}
then that looks intentional and it's more to handle the case where the node is not an ArrayNode as opposed to handling when it's null. So it could be that ItemsValidator should be changed to make it consistent but I'm hesitant to make any changes without knowing whether the actual use case is valid since you mentioned that the instance is null and not that the ArrayNode doesn't have children.

from json-schema-validator.

bartoszm avatar bartoszm commented on May 28, 2024

My use case is to walk the schema for different purposes than validation - I know this is not the main use case for your library :)

I have created a minimal use case I was trying to explain above: https://gist.github.com/bartoszm/5bdcebe01c59742ad40165c1a78a8966

What the use case demonstrates is how the walk works when data instance is provided and when data is not provided.
As you can see there is a glitch in the Matrix when you use V202012.

The result for VersionFlag.V201909:
-- with data --
$.name
$.children[0].name
$.children[0]
$.children
-- with no data --
$.name
$.children[0].name
$.children[0]
$.children

The result for VersionFlag.V202012:
-- with data --
$.name
$.children[0].name
$.children[0]
$.children
-- with no data --
$.name
$.children.name
$.children
$.children

from json-schema-validator.

justin-tay avatar justin-tay commented on May 28, 2024

As I highlighted, the walk is walking the instance data, it doesn't walk the schema, so passing null and expecting it to walk the schema just wouldn't work. For instance a ref could make a schema cyclic, and also cases where a tuple schema is used eg. with prefixItems. It only appears to work due to your specific schema and data by coincidence. There's also discrepancies in behavior when passing null and with validation turned on to walk for instance.

If there's anything to fix it would be to make the V202012 processing to be the same as the processing with V201909. Would this solve your issue, because it sounds like what you want is the opposite.

from json-schema-validator.

bartoszm avatar bartoszm commented on May 28, 2024

@justin-tay having the V202012 processing to be the same as the processing with V201909 would solve my issue.

from json-schema-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.