Using Microsoft.Data.SqlClient instead of System.Data.SqlClient about neventstore.persistence.sql HOT 12 CLOSED

closed in #44

from neventstore.persistence.sql.

Actually, we are now at a point where System.Data.SqlClient is no longer compatible with NET8.
I will create a PR for this and hope it gets some traction because we are stuck right now :(

from neventstore.persistence.sql.

Well its still compatible and we are using it with net 8. but its lacking critical features.

from neventstore.persistence.sql.

Well, compatible unless you are affected by the bug i referenced in the PR :-)
We have som reflection discovery code that breaks on net8 due to system.data.sqlclient

from neventstore.persistence.sql.

Thanks @esbenbach for your PR, there's some more work to do (like updating properly the nuspec files and fixing some references here and there).
I'll start from your code and create a spike completely replacing System.Data.SqlClient with Microsoft.Data.SqlClient even for net462 to see if all tests are green.

from neventstore.persistence.sql.

@AGiorgetti - okay, let me know if I need to do some more on it. A complete replacement would probably be easier to maintain in the long run :)

from neventstore.persistence.sql.

I wasn't able to push new commits on yout branch, so I created another one incorporating you commits (this way our build machine can run all the tests).

Take a look at this PR: #44 .

If it's all good we can close it and release a new version.

from neventstore.persistence.sql.

How are changes published to NuGet - noticed there is nothing there yet, but unaware if something manual needs to be done in order for you to publish the resulting package.

from neventstore.persistence.sql.

It should be up in minutes, I had some issues with the build agent.

from neventstore.persistence.sql.

Unfortunately i still don't see it in the releases. Did it every complete?

from neventstore.persistence.sql.

Yearh its tagged, its on nuget (and working mind you), but its missing from the releases section GH. A manual step missing presumably :)

from neventstore.persistence.sql.

oh thats amazing. finally can get rid of the old system.data.sql package completely. :)

from neventstore.persistence.sql.