Giter VIP home page Giter VIP logo

Comments (6)

Z3BRO avatar Z3BRO commented on May 26, 2024 2

Honestly, this is excellent stuff, and it would be super cool to implement. The only issue is that the SK6805 1515 Neopixels used for the RGB Backlight and the Internal RGB are extremely color inaccurate. Even if the LEDs were more color accurate, I feel like these changes would go pretty unnoticed, as this mod is really only about "ooooo pretty colors."

from momentum-firmware.

zacharyweiss avatar zacharyweiss commented on May 26, 2024 2

It's such a fun nerd-sniping hole to fall down; there's so much fascinating work in the space. The primary experiential benefit would less so be the colors themselves, and moreso on the consistency of apparent brightness as the hues change, but I definitely agree that it's likely in the noise / not worth the effort with the current degree of LED-accuracy.

If looking for an excuse to mess around with color math though, it could be worthwhile to impl for the VGM / RGB-over-RPC feature, as that gets played over an actual LCD/similar display, and more importantly: relies on the Flipper to calculate the color gradients across the screen (whereas in reality obviously the gradients are left to the literal physics of light diffusion & mixing, and the above changes would've just been for consistent brightness across the LEDs / across time)

from momentum-firmware.

zacharyweiss avatar zacharyweiss commented on May 26, 2024

Asides:

  • My knowledge on color science is limited, but presumably one could also try and modify the above matrices for an approximate quantized transformation to avoid the float BS and keep colors 16/24-bit. Would require some analysis to see what the max error that introduces is, as if it's a significant portion of the "perceptual error" that interpolating over HSV introduces, would negate the point of this whole exercise
  • There also exist variants like OKHSV which would simplify the interp/orbit modifications as it cuts out the need for any trig, just keep the same iteration approach (incrementing the H value by some step), only requiring swapping in an OKHSV<>RGB565/888 transform function

from momentum-firmware.

Willy-JL avatar Willy-JL commented on May 26, 2024

We will soon have to fully redo the rgb backlight stuff since @Z3BRO made a new rgb thing for clear cases and fully disregarded the improvements we had to rgb backlight and rainbow settings in momentum, so anything related to this color stuff will have to wait for that rework. Interesting stuff however, I'm not experienced in this myself but might be something to look into z3bro?

from momentum-firmware.

Willy-JL avatar Willy-JL commented on May 26, 2024

Also something to keep in mind is that from what I've heard, the rgb backlight are absolutely unreliable in terms of color accuracy and shown colors vary abysmally between different installed mods, so might not even be worth the hassle... just thought it would be worth mentioning, but then again I don't know and don't even have an rgb backlight

from momentum-firmware.

zacharyweiss avatar zacharyweiss commented on May 26, 2024

All good points! I'll close this given the above; can always reopen if it seems worthwhile in light of (no pun intended) reworked RGB HW (& SW support).

from momentum-firmware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.