Giter VIP home page Giter VIP logo

Comments (8)

Antreesy avatar Antreesy commented on July 1, 2024 2

The only thing I could think of is creating a global router

If that also helps to cover such app parts and cases, as UnifiedSearch / internal links in Talk messages, I'd like to try it out

Otherwise, and for that particular case, I think, 5 lines of changes locally would be sufficient

from nextcloud-vue.

Pytal avatar Pytal commented on July 1, 2024

Proposed solutions sounds good :)

Would this implementation be useful in files @skjnldsv and deck @juliushaertl as well?

from nextcloud-vue.

skjnldsv avatar skjnldsv commented on July 1, 2024

Not sure I get the context? 🤔

from nextcloud-vue.

Antreesy avatar Antreesy commented on July 1, 2024

So, in two words, this component shouldn't reload a page, when click on different conversation:
image

It is used also only in Deck atm, if I get it correct:
https://github.com/nextcloud/deck/blob/e8dd28752867acde15944e4d00c53caeb6570e3f/src/components/board/SharingTabSidebar.vue#L79

from nextcloud-vue.

skjnldsv avatar skjnldsv commented on July 1, 2024

The only thing I could think of is creating a global router that plugs into various apps to see if a clicked link does have a router match somewhere and if so, catch the page refresh. 🤔

from nextcloud-vue.

Pytal avatar Pytal commented on July 1, 2024

The only thing I could think of is creating a global router that plugs into various apps to see if a clicked link does have a router match somewhere and if so, catch the page refresh. 🤔

The intention was to scope this per app I believe

It is used also only in Deck atm, if I get it correct: nextcloud/deck@e8dd287/src/components/board/SharingTabSidebar.vue#L79

The files panel is registered in the related_resources app itself https://github.com/search?type=code&q=org%3Anextcloud+%22NcRelatedResourcesPanel%22 fyi @Antreesy

from nextcloud-vue.

skjnldsv avatar skjnldsv commented on July 1, 2024

The intention was to scope this per app I believe

But the NcResource.vue is standalone, no?
Might be worth thinking about this 🤷

from nextcloud-vue.

Antreesy avatar Antreesy commented on July 1, 2024

Fixed by #5282

from nextcloud-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.