Giter VIP home page Giter VIP logo

Comments (8)

nimishavijay avatar nimishavijay commented on July 19, 2024 1

That is a good point. Some ideas that come to mind:

  • Make the text and icon --color-text-maxcontrast so that it looks like a disabled button
  • Always add a separator under/above/both the NcActionText component so that it is separated from the rest of the buttons

Honestly I am ok with either, or even both the solutions being implemented together. What do you think @szaimen @marcoambrosini ?

from nextcloud-vue.

nimishavijay avatar nimishavijay commented on July 19, 2024 1

I am not able to find many instances of NcActionCaption at all, only 2 so far in the core apps, one in the dashboard and one in calendar. What do you think about making the caption bold, so that it's similar to NcAppNavigationCaption? I would steer clear of using center alignment as that's something we rarely do for text/headings/captions. It would look something like this

image

from nextcloud-vue.

susnux avatar susnux commented on July 19, 2024

cc @nextcloud-libraries/designers

from nextcloud-vue.

ShGKme avatar ShGKme commented on July 19, 2024
  • Make the text and icon --color-text-maxcontrast so that it looks like a disabled button

Sounds very similar to the current style of NcActionCaption, except that caption has no icon.

image

from nextcloud-vue.

ShGKme avatar ShGKme commented on July 19, 2024
  • Always add a separator under/above/both the NcActionText component so that it is separated from the rest of the buttons

I think that could be an unexpected design change. Also, a separator has a semantic value — for example, it is used to separate radio groups in menus:
image

from nextcloud-vue.

ShGKme avatar ShGKme commented on July 19, 2024

very similar to the current style of NcActionCaption

Maybe make caption centered?

image

from nextcloud-vue.

ShGKme avatar ShGKme commented on July 19, 2024

I would steer clear of using center alignment as that's something we rarely do for text/headings/captions. It would look something like this

Note, the centered "Group caption" from my screenshot is the current behavior.

from nextcloud-vue.

susnux avatar susnux commented on July 19, 2024

Maybe drop one of both and unify into one? (caption & text)

from nextcloud-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.