Image Preview Generation Fails about nextcloud-snap HOT 8 CLOSED

Uneducated guess would be that php is not compiled with libjpeg.

That sounds like a very educated guess! Sounds like we're missing a flag here. Initial research leads me to believe it's --with-jpeg-dir=<wherever libjpeg gets installed> with perhaps libjpeg-dev as a build-package. Though I'm not sure whether we need jpeg8 or jpeg9, any idea?

from nextcloud-snap.

        configflags:
...
          - --with-gd
          - --enable-gd-native-ttf
          - --with-jpeg-dir=/usr/lib
          - --with-freetype-dir=/usr/lib
    stage-packages:
...
      - libfontconfig1
      - libfreetype6
      - libjpeg8
    build-packages:
...
      - libgd-dev

Not sure if jpeg9 is a better option but it was working fine with jpeg8

from nextcloud-snap.

@oparoz are --enable-gd-native-ttf and --with-freetype-dir required for this?

from nextcloud-snap.

Not for images, but it's just the proper way to configure GD for a hosting environment so that app developers are less limited. Basic image and text manipulation in PHP is usually a given.

from nextcloud-snap.

Not for images, but it's just the proper way to configure GD for a hosting environment so that app developers are less limited. Basic image and text manipulation in PHP is usually a given.

libjpeg has an obvious use-case (this bug). Do we have a use-case for those other capabilities in Nextcloud? I don't see a big advantage to enabling things "just because"-- this all takes space and increases potential attack surfaces.

from nextcloud-snap.

The most obvious one is watermarking. If someone writes an app which adds a copyright on the image, PHP needs to have access to special methods and to system fonts. Hmmm... This last part rings a bell when trying to configure Imagemagick... fonts might not be easily accessible unless we set an env variable and we can't easily test this functionality since the root path is read-only.
Let's move that to another PR then.

from nextcloud-snap.

@shasderias @oparoz mind giving #25 a look/test? Details for how to test are over there.

from nextcloud-snap.

This was resolved in #25, and will be in the next release (at which point this bug will be closed). Thank you for the excellent bug report!

from nextcloud-snap.